Skip to content
Snippets Groups Projects
  1. Jul 12, 2022
  2. Jun 14, 2022
    • Quentin Gliech's avatar
      Move the "email unsubscribe" resource, refactor the macaroon generator &... · fe1daad6
      Quentin Gliech authored
      Move the "email unsubscribe" resource, refactor the macaroon generator & simplify the access token verification logic. (#12986)
      
      This simplifies the access token verification logic by removing the `rights`
      parameter which was only ever used for the unsubscribe link in email
      notifications. The latter has been moved under the `/_synapse` namespace,
      since it is not a standard API.
      
      This also makes the email verification link more secure, by embedding the
      app_id and pushkey in the macaroon and verifying it. This prevents the user
      from tampering the query parameters of that unsubscribe link.
      
      Macaroon generation is refactored:
      
      - Centralised all macaroon generation and verification logic to the
        `MacaroonGenerator`
      - Moved to `synapse.utils`
      - Changed the constructor to require only a `Clock`, hostname, and a secret key
        (instead of a full `Homeserver`).
      - Added tests for all methods.
      fe1daad6
  3. May 11, 2022
  4. Apr 01, 2022
  5. Feb 28, 2022
  6. Feb 23, 2022
  7. Feb 22, 2022
  8. Feb 11, 2022
    • Richard van der Hoff's avatar
      Tests: replace mocked Authenticator with the real thing (#11913) · c3db7a0b
      Richard van der Hoff authored
      If we prepopulate the test homeserver with a key for a remote homeserver, we
      can make federation requests to it without having to stub out the
      authenticator. This has two advantages:
      
       * means that what we are testing is closer to reality (ie, we now have
         complete tests for the incoming-request-authorisation flow)
      
       * some tests require that other objects be signed by the remote server (eg,
         the event in `/send_join`), and doing that would require a whole separate
         set of mocking out. It's much simpler just to use real keys.
      c3db7a0b
  9. Feb 02, 2022
  10. Dec 14, 2021
  11. Dec 07, 2021
    • Andrew Morgan's avatar
      Fix case in `wait_for_background_updates` where `self.store` does not exist (#11331) · d6fb96e0
      Andrew Morgan authored
      Pull the DataStore from the HomeServer instance, which
      always exists.
      d6fb96e0
    • Sean Quah's avatar
      Revert accidental fast-forward merge from v1.49.0rc1 · 158d73eb
      Sean Quah authored
      Revert "Sort internal changes in changelog"
      Revert "Update CHANGES.md"
      Revert "1.49.0rc1"
      Revert "Revert "Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505) (#11527)"
      Revert "Refactors in `_generate_sync_entry_for_rooms` (#11515)"
      Revert "Correctly register shutdown handler for presence workers (#11518)"
      Revert "Fix `ModuleApi.looping_background_call` for non-async functions (#11524)"
      Revert "Fix 'delete room' admin api to work on incomplete rooms (#11523)"
      Revert "Correctly ignore invites from ignored users (#11511)"
      Revert "Fix the test breakage introduced by #11435 as a result of concurrent PRs (#11522)"
      Revert "Stabilise support for MSC2918 refresh tokens as they have now been merged into the Matrix specification. (#11435)"
      Revert "Save the OIDC session ID (sid) with the device on login (#11482)"
      Revert "Add admin API to get some information about federation status (#11407)"
      Revert "Include bundled aggregations in /sync and related fixes (#11478)"
      Revert "Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505)"
      Revert "Update backward extremity docs to make it clear that it does not indicate whether we have fetched an events' `prev_events` (#11469)"
      Revert "Support configuring the lifetime of non-refreshable access tokens separately to refreshable access tokens. (#11445)"
      Revert "Add type hints to `synapse/tests/rest/admin` (#11501)"
      Revert "Revert accidental commits to develop."
      Revert "Newsfile"
      Revert "Give `tests.server.setup_test_homeserver` (nominally!) the same behaviour"
      Revert "Move `tests.utils.setup_test_homeserver` to `tests.server`"
      Revert "Convert one of the `setup_test_homeserver`s to `make_test_homeserver_synchronous`"
      Revert "Disambiguate queries on `state_key` (#11497)"
      Revert "Comments on the /sync tentacles (#11494)"
      Revert "Clean up tests.storage.test_appservice (#11492)"
      Revert "Clean up `tests.storage.test_main` to remove use of legacy code. (#11493)"
      Revert "Clean up `tests.test_visibility` to remove legacy code. (#11495)"
      Revert "Minor cleanup on recently ported doc pages  (#11466)"
      Revert "Add most of the missing type hints to `synapse.federation`. (#11483)"
      Revert "Avoid waiting for zombie processes in `synctl stop` (#11490)"
      Revert "Fix media repository failing when media store path contains symlinks (#11446)"
      Revert "Add type annotations to `tests.storage.test_appservice`. (#11488)"
      Revert "`scripts-dev/sign_json`: support for signing events (#11486)"
      Revert "Add MSC3030 experimental client and federation API endpoints to get the closest event to a given timestamp (#9445)"
      Revert "Port wiki pages to documentation website (#11402)"
      Revert "Add a license header and comment. (#11479)"
      Revert "Clean-up get_version_string (#11468)"
      Revert "Link background update controller docs to summary (#11475)"
      Revert "Additional type hints for config module. (#11465)"
      Revert "Register the login redirect endpoint for v3. (#11451)"
      Revert "Update openid.md"
      Revert "Remove mention of OIDC certification from Dex (#11470)"
      Revert "Add a note about huge pages to our Postgres doc (#11467)"
      Revert "Don't start Synapse master process if `worker_app` is set (#11416)"
      Revert "Expose worker & homeserver as entrypoints in `setup.py` (#11449)"
      Revert "Bundle relations of relations into the `/relations` result. (#11284)"
      Revert "Fix `LruCache` corruption bug with a `size_callback` that can return 0 (#11454)"
      Revert "Eliminate a few `Any`s in `LruCache` type hints (#11453)"
      Revert "Remove unnecessary `json.dumps` from `tests.rest.admin` (#11461)"
      Revert "Merge branch 'master' into develop"
      
      This reverts commit 26b5d232.
      This reverts commit bce4220f.
      This reverts commit 966b5d0f.
      This reverts commit 088d748f.
      This reverts commit 14d593f7.
      This reverts commit 2a3ec6fa.
      This reverts commit eccc49d7.
      This reverts commit b1ecd19c.
      This reverts commit 9c55dedc.
      This reverts commit 2d42e586.
      This reverts commit 2f053f3f.
      This reverts commit a15a893d.
      This reverts commit 8b4b153c.
      This reverts commit 494ebd73.
      This reverts commit a77c3698.
      This reverts commit 4eb77965.
      This reverts commit 637df95d.
      This reverts commit e5f426cd.
      This reverts commit 8cd68b81.
      This reverts commit 6cae125e.
      This reverts commit 7be88fbf.
      This reverts commit b3fd99b7.
      This reverts commit f7ec6e7d.
      This reverts commit 5640992d.
      This reverts commit d26808dd.
      This reverts commit f91624a5.
      This reverts commit 16d39a54.
      This reverts commit 8a4c2969.
      This reverts commit 49e1356e.
      This reverts commit d2279f47.
      This reverts commit b50e39df.
      This reverts commit 858d80bf.
      This reverts commit 435f0448.
      This reverts commit f61462e1.
      This reverts commit a6f1a3ab.
      This reverts commit 84dc50e1.
      This reverts commit ed635d32.
      This reverts commit 7b62791e.
      This reverts commit 153194c7.
      This reverts commit f44d729d.
      This reverts commit a265fbd3.
      This reverts commit b9fef1a7.
      This reverts commit b0eb64ff.
      This reverts commit f1795463.
      This reverts commit 70cbb1a5.
      This reverts commit 42bf0204.
      This reverts commit 379f2650.
      This reverts commit 7ff22d6d.
      This reverts commit 5a0b652d.
      This reverts commit 432a174b.
      This reverts commit b14f8a1b, reversing
      changes made to e713855d.
      158d73eb
  12. Nov 29, 2021
  13. Nov 22, 2021
  14. Nov 16, 2021
  15. Nov 12, 2021
    • David Robertson's avatar
      Misc typing fixes for `tests`, part 1 of N (#11323) · 4c96ce39
      David Robertson authored
      * Annotate HomeserverTestCase.servlets
      * Correct annotation of federation_auth_origin
      * Use AnyStr custom_headers instead of a Union
      
      This allows (str, str) and (bytes, bytes).
      This disallows (str, bytes) and (bytes, str)
      
      * DomainSpecificString.SIGIL is a ClassVar
      4c96ce39
  16. Oct 14, 2021
  17. Oct 06, 2021
  18. Oct 04, 2021
    • David Robertson's avatar
      Consistently exclude from user_directory (#10960) · f7b034a2
      David Robertson authored
      * Introduce `should_include_local_users_in_dir`
      
      We exclude three kinds of local users from the user_directory tables. At
      present we don't consistently exclude all three in the same places. This
      commit introduces a new function to gather those exclusion conditions
      together. Because we have to handle local and remote users in different
      ways, I've made that function only consider the case of remote users.
      It's the caller's responsibility to make the local versus remote
      distinction clear and correct.
      
      A test fixup is required. The test now hits a path which makes db
      queries against the users table. The expected rows were missing, because
      we were using a dummy user that hadn't actually been registered.
      
      We also add new test cases to covert the exclusion logic.
      
      ----
      
      By my reading this makes these changes:
      
      * When an app service user registers or changes their profile, they will
        _not_ be added to the user directory. (Previously only support and
        deactivated users were excluded). This is consistent with the logic that
        rebuilds the user directory. See also [the discussion
        here](https://github.com/matrix-org/synapse/pull/10914#discussion_r716859548
      
      ).
      * When rebuilding the directory, exclude support and disabled users from
        room sharing tables. Previously only appservice users were excluded.
      * Exclude all three categories of local users when rebuilding the
        directory. Previously `_populate_user_directory_process_users` didn't do
        any exclusion.
      
      Co-authored-by: default avatarRichard van der Hoff <1389908+richvdh@users.noreply.github.com>
      f7b034a2
    • Patrick Cloke's avatar
  19. Oct 01, 2021
  20. Sep 30, 2021
  21. Sep 29, 2021
  22. Sep 10, 2021
  23. Aug 20, 2021
  24. Jul 19, 2021
  25. Jul 13, 2021
  26. Apr 27, 2021
  27. Apr 23, 2021
  28. Apr 20, 2021
  29. Apr 14, 2021
  30. Apr 09, 2021
  31. Apr 08, 2021
  32. Mar 17, 2021
  33. Mar 16, 2021
  34. Feb 16, 2021
Loading