Skip to content
Snippets Groups Projects
  1. Jan 08, 2025
  2. Jan 06, 2025
  3. Jan 03, 2025
  4. Dec 18, 2024
    • Andrew Morgan's avatar
      Fix mypy errors on Twisted 24.11.0 (#17998) · 3eb92369
      Andrew Morgan authored
      Fixes various `mypy` errors associated with Twisted `24.11.0`.
      
      Hopefully addresses https://github.com/element-hq/synapse/issues/17075,
      though I've yet to test against `trunk`.
      
      Changes should be compatible with our currently pinned Twisted version
      of `24.7.0`.
      3eb92369
    • Andrew Morgan's avatar
      Bump mypy from 1.11.2 to 1.12.1 and fix new typechecking errors (#17999) · f1b0f9a4
      Andrew Morgan authored
      Supersedes https://github.com/element-hq/synapse/pull/17958.
      
      Awkwardly, the changes made to fix the mypy errors in 1.12.1 cause
      errors in 1.11.2. So you'll need to update your mypy version to 1.12.1
      to eliminate typechecking errors during developing.
      f1b0f9a4
    • cynhr's avatar
      Add email.tlsname config option (#17849) · f1ecf466
      cynhr authored
      The existing `email.smtp_host` config option is used for two distinct
      purposes: it is resolved into the IP address to connect to, and used to
      (request via SNI and) validate the server's certificate if TLS is
      enabled. This new option allows specifying a different name for the
      second purpose.
      
      This is especially helpful, if `email.smtp_host` isn't a global FQDN,
      but something that resolves only locally (e.g. "localhost" to connect
      through the loopback interface, or some other internally routed name),
      that one cannot get a valid certificate for.
      Alternatives would of course be to specify a global FQDN as
      `email.smtp_host`, or to disable TLS entirely, both of which might be
      undesirable, depending on the SMTP server configuration.
      f1ecf466
  5. Dec 17, 2024
    • V02460's avatar
      Add `macaroon_secret_key_path` config option (#17983) · 57bf4494
      V02460 authored
      Another config option on my quest to a `*_path` variant for every
      secret. This time it’s `macaroon_secret_key_path`.
      
      Reading secrets from files has the security advantage of separating the secrets from the config. It also simplifies secrets management in Kubernetes. Also useful to NixOS users.
      57bf4494
  6. Dec 16, 2024
    • Shay's avatar
      Add some useful endpoints to Admin API (#17948) · 8208186e
      Shay authored
      - Fetch the number of invites the provided user has sent after a given
      timestamp
      - Fetch the number of rooms the provided user has joined after a given
      timestamp, regardless if they have left/been banned from the rooms
      subsequently
      - Get report IDs of event reports where the provided user was the sender
      of the reported event
      8208186e
  7. Dec 13, 2024
  8. Dec 04, 2024
  9. Dec 03, 2024
  10. Dec 02, 2024
  11. Nov 29, 2024
  12. Nov 28, 2024
    • Richard van der Hoff's avatar
      Fix new scheduled tasks jumping the queue (#17962) · d80cd57c
      Richard van der Hoff authored
      Currently, when a new scheduled task is added and its scheduled time has
      already passed, we set it to ACTIVE. This is problematic, because it
      means it will jump the queue ahead of all other SCHEDULED tasks;
      furthermore, if the Synapse process gets restarted, it will jump ahead
      of any ACTIVE tasks which have been started but are taking a while to
      run.
      
      Instead, we leave it set to SCHEDULED, but kick off a call to
      `_launch_scheduled_tasks`, which will decide if we actually have
      capacity to start a new task, and start the newly-added task if so.
      d80cd57c
  13. Nov 25, 2024
    • Erik Johnston's avatar
      Fix up logic for delaying sending read receipts over federation. (#17933) · 3943d2fd
      Erik Johnston authored
      For context of why we delay read receipts, see
      https://github.com/matrix-org/synapse/issues/4730.
      
      Element Web often sends read receipts in quick succession, if it reloads
      the timeline it'll send one for the last message in the old timeline and
      again for the last message in the new timeline. This caused remote users
      to see a read receipt for older messages come through quickly, but then
      the second read receipt taking a while to arrive for the most recent
      message.
      
      There are two things going on in this PR:
      1. There was a mismatch between seconds and milliseconds, and so we
      ended up delaying for far longer than intended.
      2. Changing the logic to reuse the `DestinationWakeupQueue` (used for
      presence)
      
      The changes in logic are:
      - Treat the first receipt and subsequent receipts in a room in the same
      way
      - Whitelist certain classes of receipts to never delay being sent, i.e.
      receipts in small rooms, receipts for events that were sent within the
      last 60s, and sending receipts to the event sender's server.
      - The maximum delay a receipt can have before being sent to a server is
      30s, and we'll send out receipts to remotes at least at 50Hz (by
      default)
      
      The upshot is that this should make receipts feel more snappy over
      federation.
      
      This new logic should send roughly between 10%–20% of transactions
      immediately on matrix.org.
      3943d2fd
  14. Nov 22, 2024
  15. Nov 20, 2024
  16. Nov 19, 2024
  17. Nov 13, 2024
  18. Nov 12, 2024
  19. Nov 08, 2024
    • Erik Johnston's avatar
      Fix MSC4222 returning full state (#17915) · cacd4fd7
      Erik Johnston authored
      There was a bug that meant we would return the full state of the room on
      incremental syncs when using lazy loaded members and there were no
      entries in the timeline.
      
      This was due to trying to use `state_filter or state_filter.all()` as a
      short hand for handling `None` case, however `state_filter` implements
      `__bool__` so if the state filter was empty it would be set to full.
      
      c.f. MSC4222 and #17888
      cacd4fd7
  20. Nov 07, 2024
  21. Nov 06, 2024
  22. Nov 05, 2024
    • Alexander Udovichenko's avatar
      Fix WheelTimer implementation that can expired timeout early (#17850) · 211c31db
      Alexander Udovichenko authored
      When entries insert in the end of timer queue, then unnecessary entry
      inserted (with duplicated key).
      This can lead to some timeouts expired early and consume memory.
      211c31db
    • Erik Johnston's avatar
      Add experimental support for MSC4222 (#17888) · 361bdafb
      Erik Johnston authored
      Basically, if the client sets a special query param on `/sync` v2
      instead of responding with `state` at the *start* of the timeline, we
      instead respond with `state_after` at the *end* of the timeline.
      
      We do this by using the `current_state_delta_stream` table, which is
      actually reliable, rather than messing around with "state at" points on
      the timeline.
      
      c.f. MSC4222
      361bdafb
  23. Nov 04, 2024
  24. Oct 31, 2024
  25. Oct 30, 2024
  26. Oct 29, 2024
  27. Oct 23, 2024
  28. Oct 22, 2024
  29. Oct 17, 2024
Loading