Skip to content
Snippets Groups Projects
  1. Feb 17, 2023
  2. Feb 16, 2023
  3. Feb 15, 2023
  4. Feb 09, 2023
  5. Feb 08, 2023
  6. Feb 01, 2023
  7. Jan 31, 2023
  8. Jan 30, 2023
  9. Jan 25, 2023
  10. Jan 24, 2023
  11. Jan 19, 2023
  12. Jan 18, 2023
  13. Jan 17, 2023
    • David Robertson's avatar
      Require poetry>=1.3.2 (#14860) · b88cfe6d
      David Robertson authored
      
      * Upgrade to new lockfile format
      
      Now requires poetry >= 1.2.2 to read and poetry >= 1.3.0 to write.
      
      Cheat sheet:
      
      ```
      poetry --version
      poetry show > scratch/before
      pipx upgrade poetry
      poetry --version
      poetry show > scratch/after
      diff scratch{before,after} && echo "no change!"
      ```
      
      * Use Poetry 1.3.2 when reading or writing lockfile
      
      * Remove unneeded(?) poetry dep for cibuildwheel
      
      * Update docs
      
      * Remove redundant call to setup-python
      
      * Remove outdated comments related to Poetry 1.x
      
      * Remove outdated docs line
      
      was fixed in #13082
      
      * Minor improvements to poetry cheat sheet
      
      * Invoke setup-python-poetry with explicit version
      
      Not sure about this. It's hardcoding versions everywhere.
      
      * Changelog
      
      * Check the lockfile is version 2.0
      
      Might one day incorporate other checks like #14742
      
      * Typo fixes, thanks Sean
      
      Co-authored-by: default avatarSean Quah <8349537+squahtx@users.noreply.github.com>
      
      Co-authored-by: default avatarSean Quah <8349537+squahtx@users.noreply.github.com>
      Unverified
      b88cfe6d
    • Erik Johnston's avatar
  14. Jan 16, 2023
    • Rhea Danzey's avatar
      Fix missing field in AS documentation (#14845) · 7801fd74
      Rhea Danzey authored
      * Fix missing field in AS documentation
      
      The [AS Configuration Snippet](https://matrix-org.github.io/synapse/latest/application_services.html) is missing `id` field, without it Synapse will fail to load:
      
      ```
      synapse-synapse-main-0 synapse 2023-01-13 23:05:25,450 - synapse.storage.databases - 84 - INFO - main - [database config 'master']: Starting 'main' database
      synapse-synapse-main-0 synapse 2023-01-13 23:05:25,452 - synapse.config.appservice - 79 - ERROR - main - Failed to load appservice from '/as/synapse-hookshot-as/registration.yaml'
      synapse-synapse-main-0 synapse 2023-01-13 23:05:25,452 - synapse.config.appservice - 80 - ERROR - main - "Required string field: 'id' (/as/synapse-hookshot-as/registration.yaml)"
      synapse-synapse-main-0 synapse Traceback (most recent call last):
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/config/appservice.py", line 57, in load_appservices
      synapse-synapse-main-0 synapse     appservice = _load_appservice(hostname, yaml.safe_load(f), config_file)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/config/appservice.py", line 91, in _load_appservice
      synapse-synapse-main-0 synapse     raise KeyError(
      synapse-synapse-main-0 synapse KeyError: "Required string field: 'id' (/as/synapse-hookshot-as/registration.yaml)"
      synapse-synapse-main-0 synapse 2023-01-13 23:05:25,452 - synapse.app._base - 207 - ERROR - main - Exception during startup
      synapse-synapse-main-0 synapse Traceback (most recent call last):
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/app/homeserver.py", line 340, in setup
      synapse-synapse-main-0 synapse     hs.setup()
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/server.py", line 310, in setup
      synapse-synapse-main-0 synapse     self.datastores = Databases(self.DATASTORE_CLASS, self)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/__init__.py", line 93, in __init__
      synapse-synapse-main-0 synapse     main = main_store_class(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/__init__.py", line 139, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/events_bg_updates.py", line 98, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/devices.py", line 1584, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/devices.py", line 89, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/roommember.py", line 1494, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/room.py", line 1827, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/room.py", line 1365, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/room.py", line 119, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/registration.py", line 2158, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/presence.py", line 67, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/presence.py", line 48, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/transactions.py", line 73, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/state.py", line 666, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/state.py", line 82, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/state.py", line 470, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/event_federation.py", line 2007, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/media_repository.py", line 148, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/media_repository.py", line 68, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/push_rule.py", line 330, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/event_push_actions.py", line 1938, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/metrics.py", line 68, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/event_push_actions.py", line 249, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/end_to_end_keys.py", line 1181, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/search.py", line 426, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/search.py", line 137, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/account_data.py", line 64, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/push_rule.py", line 114, in __init__
      synapse-synapse-main-0 synapse     super().__init__(database, db_conn, hs)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/storage/databases/main/appservice.py", line 76, in __init__
      synapse-synapse-main-0 synapse     self.services_cache = load_appservices(
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/config/appservice.py", line 57, in load_appservices
      synapse-synapse-main-0 synapse     appservice = _load_appservice(hostname, yaml.safe_load(f), config_file)
      synapse-synapse-main-0 synapse   File "/usr/local/lib/python3.9/site-packages/synapse/config/appservice.py", line 91, in _load_appservice
      synapse-synapse-main-0 synapse     raise KeyError(
      synapse-synapse-main-0 synapse KeyError: "Required string field: 'id' (/as/synapse-hookshot-as/registration.yaml)"
      synapse-synapse-main-0 synapse ******************************************************************************
      synapse-synapse-main-0 synapse  Error during initialisation:
      synapse-synapse-main-0 synapse     "Required string field: 'id' (/as/synapse-hookshot-as/registration.yaml)"
      synapse-synapse-main-0 synapse  There may be more information in the logs.
      synapse-synapse-main-0 synapse ******************************************************************************
      ```
      
      * Changelog
      Unverified
      7801fd74
  15. Jan 13, 2023
  16. Jan 11, 2023
  17. Jan 09, 2023
  18. Jan 05, 2023
  19. Jan 04, 2023
  20. Dec 28, 2022
  21. Dec 21, 2022
  22. Dec 20, 2022
  23. Dec 15, 2022
  24. Dec 13, 2022
    • David Robertson's avatar
      Declare support for Python 3.11 (#14673) · d567a826
      David Robertson authored
      * Declare support for Python 3.11
      
      * Changelog
      Unverified
      d567a826
    • David Robertson's avatar
      Allow selecting "prejoin" events by state keys (#14642) · e2a1adbf
      David Robertson authored
      * Declare new config
      
      * Parse new config
      
      * Read new config
      
      * Don't use trial/our TestCase where it's not needed
      
      Before:
      
      ```
      $ time trial tests/events/test_utils.py > /dev/null
      
      real	0m2.277s
      user	0m2.186s
      sys	0m0.083s
      ```
      
      After:
      ```
      $ time trial tests/events/test_utils.py > /dev/null
      
      real	0m0.566s
      user	0m0.508s
      sys	0m0.056s
      ```
      
      * Helper to upsert to event fields
      
      without exceeding size limits.
      
      * Use helper when adding invite/knock state
      
      Now that we allow admins to include events in prejoin room state with
      arbitrary state keys, be a good Matrix citizen and ensure they don't
      accidentally create an oversized event.
      
      * Changelog
      
      * Move StateFilter tests
      
      should have done this in #14668
      
      * Add extra methods to StateFilter
      
      * Use StateFilter
      
      * Ensure test file enforces typed defs; alphabetise
      
      * Workaround surprising get_current_state_ids
      
      * Whoops, fix mypy
      Unverified
      e2a1adbf
Loading