Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
synapse
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Monitor
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Maunium
synapse
Commits
8bc5d140
Unverified
Commit
8bc5d140
authored
2 years ago
by
Patrick Cloke
Committed by
GitHub
2 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Document how to handle Dependabot pull requests. (#14916)
parent
836c592f
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
changelog.d/14916.misc
+1
-0
1 addition, 0 deletions
changelog.d/14916.misc
docs/development/dependencies.md
+14
-0
14 additions, 0 deletions
docs/development/dependencies.md
with
15 additions
and
0 deletions
changelog.d/14916.misc
0 → 100644
+
1
−
0
View file @
8bc5d140
Document how to handle Dependabot pull requests.
This diff is collapsed.
Click to expand it.
docs/development/dependencies.md
+
14
−
0
View file @
8bc5d140
...
...
@@ -258,6 +258,20 @@ because [`build`](https://github.com/pypa/build) is a standardish tool which
doesn't require poetry. (It's what we use in CI too). However, you could try
`poetry build`
too.
## ...handle a Dependabot pull request?
Synapse uses Dependabot to keep the
`poetry.lock`
file up-to-date. When it
creates a pull request a GitHub Action will run to automatically create a changelog
file. Ensure that:
*
the lockfile changes look reasonable;
*
the upstream changelog file (linked in the description) doesn't include any
breaking changes;
*
continuous integration passes (due to permissions, the GitHub Actions run on
the changelog commit will fail, look at the initial commit of the pull request);
In particular, any updates to the type hints (usually packages which start with
`types-`
)
should be safe to merge if linting passes.
# Troubleshooting
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment