Skip to content
Snippets Groups Projects
  1. Oct 12, 2022
  2. Aug 01, 2022
  3. Jul 07, 2022
  4. Jul 05, 2022
  5. Jul 01, 2022
  6. Jun 15, 2022
  7. Jun 14, 2022
  8. Jun 09, 2022
  9. Jun 08, 2022
  10. May 24, 2022
  11. May 23, 2022
  12. May 09, 2022
  13. Apr 21, 2022
  14. Apr 11, 2022
  15. Mar 30, 2022
  16. Mar 03, 2022
  17. Feb 23, 2022
  18. Jan 20, 2022
  19. Jan 12, 2022
  20. Jan 10, 2022
  21. Dec 14, 2021
  22. Dec 07, 2021
    • Sean Quah's avatar
      Revert accidental fast-forward merge from v1.49.0rc1 · 158d73eb
      Sean Quah authored
      Revert "Sort internal changes in changelog"
      Revert "Update CHANGES.md"
      Revert "1.49.0rc1"
      Revert "Revert "Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505) (#11527)"
      Revert "Refactors in `_generate_sync_entry_for_rooms` (#11515)"
      Revert "Correctly register shutdown handler for presence workers (#11518)"
      Revert "Fix `ModuleApi.looping_background_call` for non-async functions (#11524)"
      Revert "Fix 'delete room' admin api to work on incomplete rooms (#11523)"
      Revert "Correctly ignore invites from ignored users (#11511)"
      Revert "Fix the test breakage introduced by #11435 as a result of concurrent PRs (#11522)"
      Revert "Stabilise support for MSC2918 refresh tokens as they have now been merged into the Matrix specification. (#11435)"
      Revert "Save the OIDC session ID (sid) with the device on login (#11482)"
      Revert "Add admin API to get some information about federation status (#11407)"
      Revert "Include bundled aggregations in /sync and related fixes (#11478)"
      Revert "Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505)"
      Revert "Update backward extremity docs to make it clear that it does not indicate whether we have fetched an events' `prev_events` (#11469)"
      Revert "Support configuring the lifetime of non-refreshable access tokens separately to refreshable access tokens. (#11445)"
      Revert "Add type hints to `synapse/tests/rest/admin` (#11501)"
      Revert "Revert accidental commits to develop."
      Revert "Newsfile"
      Revert "Give `tests.server.setup_test_homeserver` (nominally!) the same behaviour"
      Revert "Move `tests.utils.setup_test_homeserver` to `tests.server`"
      Revert "Convert one of the `setup_test_homeserver`s to `make_test_homeserver_synchronous`"
      Revert "Disambiguate queries on `state_key` (#11497)"
      Revert "Comments on the /sync tentacles (#11494)"
      Revert "Clean up tests.storage.test_appservice (#11492)"
      Revert "Clean up `tests.storage.test_main` to remove use of legacy code. (#11493)"
      Revert "Clean up `tests.test_visibility` to remove legacy code. (#11495)"
      Revert "Minor cleanup on recently ported doc pages  (#11466)"
      Revert "Add most of the missing type hints to `synapse.federation`. (#11483)"
      Revert "Avoid waiting for zombie processes in `synctl stop` (#11490)"
      Revert "Fix media repository failing when media store path contains symlinks (#11446)"
      Revert "Add type annotations to `tests.storage.test_appservice`. (#11488)"
      Revert "`scripts-dev/sign_json`: support for signing events (#11486)"
      Revert "Add MSC3030 experimental client and federation API endpoints to get the closest event to a given timestamp (#9445)"
      Revert "Port wiki pages to documentation website (#11402)"
      Revert "Add a license header and comment. (#11479)"
      Revert "Clean-up get_version_string (#11468)"
      Revert "Link background update controller docs to summary (#11475)"
      Revert "Additional type hints for config module. (#11465)"
      Revert "Register the login redirect endpoint for v3. (#11451)"
      Revert "Update openid.md"
      Revert "Remove mention of OIDC certification from Dex (#11470)"
      Revert "Add a note about huge pages to our Postgres doc (#11467)"
      Revert "Don't start Synapse master process if `worker_app` is set (#11416)"
      Revert "Expose worker & homeserver as entrypoints in `setup.py` (#11449)"
      Revert "Bundle relations of relations into the `/relations` result. (#11284)"
      Revert "Fix `LruCache` corruption bug with a `size_callback` that can return 0 (#11454)"
      Revert "Eliminate a few `Any`s in `LruCache` type hints (#11453)"
      Revert "Remove unnecessary `json.dumps` from `tests.rest.admin` (#11461)"
      Revert "Merge branch 'master' into develop"
      
      This reverts commit 26b5d232.
      This reverts commit bce4220f.
      This reverts commit 966b5d0f.
      This reverts commit 088d748f.
      This reverts commit 14d593f7.
      This reverts commit 2a3ec6fa.
      This reverts commit eccc49d7.
      This reverts commit b1ecd19c.
      This reverts commit 9c55dedc.
      This reverts commit 2d42e586.
      This reverts commit 2f053f3f.
      This reverts commit a15a893d.
      This reverts commit 8b4b153c.
      This reverts commit 494ebd73.
      This reverts commit a77c3698.
      This reverts commit 4eb77965.
      This reverts commit 637df95d.
      This reverts commit e5f426cd.
      This reverts commit 8cd68b81.
      This reverts commit 6cae125e.
      This reverts commit 7be88fbf.
      This reverts commit b3fd99b7.
      This reverts commit f7ec6e7d.
      This reverts commit 5640992d.
      This reverts commit d26808dd.
      This reverts commit f91624a5.
      This reverts commit 16d39a54.
      This reverts commit 8a4c2969.
      This reverts commit 49e1356e.
      This reverts commit d2279f47.
      This reverts commit b50e39df.
      This reverts commit 858d80bf.
      This reverts commit 435f0448.
      This reverts commit f61462e1.
      This reverts commit a6f1a3ab.
      This reverts commit 84dc50e1.
      This reverts commit ed635d32.
      This reverts commit 7b62791e.
      This reverts commit 153194c7.
      This reverts commit f44d729d.
      This reverts commit a265fbd3.
      This reverts commit b9fef1a7.
      This reverts commit b0eb64ff.
      This reverts commit f1795463.
      This reverts commit 70cbb1a5.
      This reverts commit 42bf0204.
      This reverts commit 379f2650.
      This reverts commit 7ff22d6d.
      This reverts commit 5a0b652d.
      This reverts commit 432a174b.
      This reverts commit b14f8a1b, reversing
      changes made to e713855d.
      158d73eb
  23. Nov 29, 2021
  24. Nov 19, 2021
  25. Nov 17, 2021
  26. Oct 22, 2021
  27. Aug 25, 2021
  28. Aug 04, 2021
    • Eric Eastwood's avatar
      Add support for MSC2716 marker events (#10498) · 684d19a1
      Eric Eastwood authored
      * Make historical messages available to federated servers
      
      Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
      
      Follow-up to https://github.com/matrix-org/synapse/pull/9247
      
      * Debug message not available on federation
      
      * Add base starting insertion point when no chunk ID is provided
      
      * Fix messages from multiple senders in historical chunk
      
      Follow-up to https://github.com/matrix-org/synapse/pull/9247
      
      Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
      
      ---
      
      Previously, Synapse would throw a 403,
      `Cannot force another user to join.`,
      because we were trying to use `?user_id` from a single virtual user
      which did not match with messages from other users in the chunk.
      
      * Remove debug lines
      
      * Messing with selecting insertion event extremeties
      
      * Move db schema change to new version
      
      * Add more better comments
      
      * Make a fake requester with just what we need
      
      See https://github.com/matrix-org/synapse/pull/10276#discussion_r660999080
      
      * Store insertion events in table
      
      * Make base insertion event float off on its own
      
      See https://github.com/matrix-org/synapse/pull/10250#issuecomment-875711889
      
      Conflicts:
      	synapse/rest/client/v1/room.py
      
      * Validate that the app service can actually control the given user
      
      See https://github.com/matrix-org/synapse/pull/10276#issuecomment-876316455
      
      Conflicts:
      	synapse/rest/client/v1/room.py
      
      * Add some better comments on what we're trying to check for
      
      * Continue debugging
      
      * Share validation logic
      
      * Add inserted historical messages to /backfill response
      
      * Remove debug sql queries
      
      * Some marker event implemntation trials
      
      * Clean up PR
      
      * Rename insertion_event_id to just event_id
      
      * Add some better sql comments
      
      * More accurate description
      
      * Add changelog
      
      * Make it clear what MSC the change is part of
      
      * Add more detail on which insertion event came through
      
      * Address review and improve sql queries
      
      * Only use event_id as unique constraint
      
      * Fix test case where insertion event is already in the normal DAG
      
      * Remove debug changes
      
      * Add support for MSC2716 marker events
      
      * Process markers when we receive it over federation
      
      * WIP: make hs2 backfill historical messages after marker event
      
      * hs2 to better ask for insertion event extremity
      
      But running into the `sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group`
      error
      
      * Add insertion_event_extremities table
      
      * Switch to chunk events so we can auth via power_levels
      
      Previously, we were using `content.chunk_id` to connect one
      chunk to another. But these events can be from any `sender`
      and we can't tell who should be able to send historical events.
      We know we only want the application service to do it but these
      events have the sender of a real historical message, not the
      application service user ID as the sender. Other federated homeservers
      also have no indicator which senders are an application service on
      the originating homeserver.
      
      So we want to auth all of the MSC2716 events via power_levels
      and have them be sent by the application service with proper
      PL levels in the room.
      
      * Switch to chunk events for federation
      
      * Add unstable room version to support new historical PL
      
      * Messy: Fix undefined state_group for federated historical events
      
      ```
      2021-07-13 02:27:57,810 - synapse.handlers.federation - 1248 - ERROR - GET-4 - Failed to backfill from hs1 because NOT NULL constraint failed: event_to_state_groups.state_group
      Traceback (most recent call last):
        File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1216, in try_backfill
          await self.backfill(
        File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1035, in backfill
          await self._auth_and_persist_event(dest, event, context, backfilled=True)
        File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2222, in _auth_and_persist_event
          await self._run_push_actions_and_persist_event(event, context, backfilled)
        File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2244, in _run_push_actions_and_persist_event
          await self.persist_events_and_notify(
        File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 3290, in persist_events_and_notify
          events, max_stream_token = await self.storage.persistence.persist_events(
        File "/usr/local/lib/python3.8/site-packages/synapse/logging/opentracing.py", line 774, in _trace_inner
          return await func(*args, **kwargs)
        File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 320, in persist_events
          ret_vals = await yieldable_gather_results(enqueue, partitioned.items())
        File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 237, in handle_queue_loop
          ret = await self._per_item_callback(
        File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 577, in _persist_event_batch
          await self.persist_events_store._persist_events_and_state_updates(
        File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 176, in _persist_events_and_state_updates
          await self.db_pool.runInteraction(
        File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 681, in runInteraction
          result = await self.runWithConnection(
        File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 770, in runWithConnection
          return await make_deferred_yieldable(
        File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 238, in inContext
          result = inContext.theWork()  # type: ignore[attr-defined]
        File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 254, in <lambda>
          inContext.theWork = lambda: context.call(  # type: ignore[attr-defined]
        File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 118, in callWithContext
          return self.currentContext().callWithContext(ctx, func, *args, **kw)
        File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 83, in callWithContext
          return func(*args, **kw)
        File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 293, in _runWithConnection
          compat.reraise(excValue, excTraceback)
        File "/usr/local/lib/python3.8/site-packages/twisted/python/deprecate.py", line 298, in deprecatedFunction
          return function(*args, **kwargs)
        File "/usr/local/lib/python3.8/site-packages/twisted/python/compat.py", line 403, in reraise
          raise exception.with_traceback(traceback)
        File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 284, in _runWithConnection
          result = func(conn, *args, **kw)
        File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 765, in inner_func
          return func(db_conn, *args, **kwargs)
        File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 549, in new_transaction
          r = func(cursor, *args, **kwargs)
        File "/usr/local/lib/python3.8/site-packages/synapse/logging/utils.py", line 69, in wrapped
          return f(*args, **kwargs)
        File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 385, in _persist_events_txn
          self._store_event_state_mappings_txn(txn, events_and_contexts)
        File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 2065, in _store_event_state_mappings_txn
          self.db_pool.simple_insert_many_txn(
        File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 923, in simple_insert_many_txn
          txn.execute_batch(sql, vals)
        File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 280, in execute_batch
          self.executemany(sql, args)
        File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 300, in executemany
          self._do_execute(self.txn.executemany, sql, *args)
        File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 330, in _do_execute
          return func(sql, *args)
      sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group
      ```
      
      * Revert "Messy: Fix undefined state_group for federated historical events"
      
      This reverts commit 187ab28611546321e02770944c86f30ee2bc742a.
      
      * Fix federated events being rejected for no state_groups
      
      Add fix from https://github.com/matrix-org/synapse/pull/10439
      until it merges.
      
      * Adapting to experimental room version
      
      * Some log cleanup
      
      * Add better comments around extremity fetching code and why
      
      * Rename to be more accurate to what the function returns
      
      * Add changelog
      
      * Ignore rejected events
      
      * Use simplified upsert
      
      * Add Erik's explanation of extra event checks
      
      See https://github.com/matrix-org/synapse/pull/10498#discussion_r680880332
      
      * Clarify that the depth is not directly correlated to the backwards extremity that we return
      
      See https://github.com/matrix-org/synapse/pull/10498#discussion_r681725404
      
      * lock only matters for sqlite
      
      See https://github.com/matrix-org/synapse/pull/10498#discussion_r681728061
      
      * Move new SQL changes to its own delta file
      
      * Clean up upsert docstring
      
      * Bump database schema version (62)
      Unverified
      684d19a1
  29. Jul 27, 2021
  30. Jul 22, 2021
  31. Jun 23, 2021
  32. Jun 22, 2021
  33. May 24, 2021
  34. Apr 09, 2021
  35. Apr 08, 2021
  36. Mar 31, 2021
    • Andrew Morgan's avatar
      Rewrite complement.sh (#9685) · ac99774d
      Andrew Morgan authored
      This PR rewrites the original complement.sh script with a number of improvements:
      
      * We can now use a local checkout of Complement (configurable with `COMPLEMENT_DIR`), though the default behaviour still downloads the master branch.
      * You can now specify a regex of test names to run, or just run all tests.
      * We now use the Synapse test blacklist tag (so all tests will pass).
      Unverified
      ac99774d
Loading