Skip to content
Snippets Groups Projects
  1. Dec 07, 2022
  2. Jun 01, 2022
  3. Feb 23, 2022
  4. Feb 02, 2022
  5. Dec 14, 2021
  6. Dec 07, 2021
    • Sean Quah's avatar
      Revert accidental fast-forward merge from v1.49.0rc1 · 158d73eb
      Sean Quah authored
      Revert "Sort internal changes in changelog"
      Revert "Update CHANGES.md"
      Revert "1.49.0rc1"
      Revert "Revert "Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505) (#11527)"
      Revert "Refactors in `_generate_sync_entry_for_rooms` (#11515)"
      Revert "Correctly register shutdown handler for presence workers (#11518)"
      Revert "Fix `ModuleApi.looping_background_call` for non-async functions (#11524)"
      Revert "Fix 'delete room' admin api to work on incomplete rooms (#11523)"
      Revert "Correctly ignore invites from ignored users (#11511)"
      Revert "Fix the test breakage introduced by #11435 as a result of concurrent PRs (#11522)"
      Revert "Stabilise support for MSC2918 refresh tokens as they have now been merged into the Matrix specification. (#11435)"
      Revert "Save the OIDC session ID (sid) with the device on login (#11482)"
      Revert "Add admin API to get some information about federation status (#11407)"
      Revert "Include bundled aggregations in /sync and related fixes (#11478)"
      Revert "Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505)"
      Revert "Update backward extremity docs to make it clear that it does not indicate whether we have fetched an events' `prev_events` (#11469)"
      Revert "Support configuring the lifetime of non-refreshable access tokens separately to refreshable access tokens. (#11445)"
      Revert "Add type hints to `synapse/tests/rest/admin` (#11501)"
      Revert "Revert accidental commits to develop."
      Revert "Newsfile"
      Revert "Give `tests.server.setup_test_homeserver` (nominally!) the same behaviour"
      Revert "Move `tests.utils.setup_test_homeserver` to `tests.server`"
      Revert "Convert one of the `setup_test_homeserver`s to `make_test_homeserver_synchronous`"
      Revert "Disambiguate queries on `state_key` (#11497)"
      Revert "Comments on the /sync tentacles (#11494)"
      Revert "Clean up tests.storage.test_appservice (#11492)"
      Revert "Clean up `tests.storage.test_main` to remove use of legacy code. (#11493)"
      Revert "Clean up `tests.test_visibility` to remove legacy code. (#11495)"
      Revert "Minor cleanup on recently ported doc pages  (#11466)"
      Revert "Add most of the missing type hints to `synapse.federation`. (#11483)"
      Revert "Avoid waiting for zombie processes in `synctl stop` (#11490)"
      Revert "Fix media repository failing when media store path contains symlinks (#11446)"
      Revert "Add type annotations to `tests.storage.test_appservice`. (#11488)"
      Revert "`scripts-dev/sign_json`: support for signing events (#11486)"
      Revert "Add MSC3030 experimental client and federation API endpoints to get the closest event to a given timestamp (#9445)"
      Revert "Port wiki pages to documentation website (#11402)"
      Revert "Add a license header and comment. (#11479)"
      Revert "Clean-up get_version_string (#11468)"
      Revert "Link background update controller docs to summary (#11475)"
      Revert "Additional type hints for config module. (#11465)"
      Revert "Register the login redirect endpoint for v3. (#11451)"
      Revert "Update openid.md"
      Revert "Remove mention of OIDC certification from Dex (#11470)"
      Revert "Add a note about huge pages to our Postgres doc (#11467)"
      Revert "Don't start Synapse master process if `worker_app` is set (#11416)"
      Revert "Expose worker & homeserver as entrypoints in `setup.py` (#11449)"
      Revert "Bundle relations of relations into the `/relations` result. (#11284)"
      Revert "Fix `LruCache` corruption bug with a `size_callback` that can return 0 (#11454)"
      Revert "Eliminate a few `Any`s in `LruCache` type hints (#11453)"
      Revert "Remove unnecessary `json.dumps` from `tests.rest.admin` (#11461)"
      Revert "Merge branch 'master' into develop"
      
      This reverts commit 26b5d232.
      This reverts commit bce4220f.
      This reverts commit 966b5d0f.
      This reverts commit 088d748f.
      This reverts commit 14d593f7.
      This reverts commit 2a3ec6fa.
      This reverts commit eccc49d7.
      This reverts commit b1ecd19c.
      This reverts commit 9c55dedc.
      This reverts commit 2d42e586.
      This reverts commit 2f053f3f.
      This reverts commit a15a893d.
      This reverts commit 8b4b153c.
      This reverts commit 494ebd73.
      This reverts commit a77c3698.
      This reverts commit 4eb77965.
      This reverts commit 637df95d.
      This reverts commit e5f426cd.
      This reverts commit 8cd68b81.
      This reverts commit 6cae125e.
      This reverts commit 7be88fbf.
      This reverts commit b3fd99b7.
      This reverts commit f7ec6e7d.
      This reverts commit 5640992d.
      This reverts commit d26808dd.
      This reverts commit f91624a5.
      This reverts commit 16d39a54.
      This reverts commit 8a4c2969.
      This reverts commit 49e1356e.
      This reverts commit d2279f47.
      This reverts commit b50e39df.
      This reverts commit 858d80bf.
      This reverts commit 435f0448.
      This reverts commit f61462e1.
      This reverts commit a6f1a3ab.
      This reverts commit 84dc50e1.
      This reverts commit ed635d32.
      This reverts commit 7b62791e.
      This reverts commit 153194c7.
      This reverts commit f44d729d.
      This reverts commit a265fbd3.
      This reverts commit b9fef1a7.
      This reverts commit b0eb64ff.
      This reverts commit f1795463.
      This reverts commit 70cbb1a5.
      This reverts commit 42bf0204.
      This reverts commit 379f2650.
      This reverts commit 7ff22d6d.
      This reverts commit 5a0b652d.
      This reverts commit 432a174b.
      This reverts commit b14f8a1b, reversing
      changes made to e713855d.
      158d73eb
  7. Nov 29, 2021
  8. Oct 15, 2021
  9. Oct 13, 2021
  10. Oct 06, 2021
  11. Oct 05, 2021
    • David Robertson's avatar
      Fix potential leak of per-room profiles when the user dir is rebuilt. (#10981) · 4f00432c
      David Robertson authored
      
      There are two steps to rebuilding the user directory:
      
      1. a scan over rooms, followed by
      2. a scan over local users.
      
      The former reads avatars and display names from the `room_memberships`
      table and therefore contains potentially private avatars and
      display names. The latter reads from the the `profiles` table which only
      contains public data; moreover it will overwrite any private profiles
      that the rooms scan may have written to the user directory. This means
      that the rebuild could leak private user while the rebuild was in
      progress, only to later cover up the leaks once the rebuild had completed.
      
      This change skips over local users when writing user_directory rows
      when scanning rooms. Doing so means that it'll take longer for a rebuild
      to make local users searchable, which is unfortunate. I think a future
      PR can improve this by swapping the order of the two steps above. (And
      indeed there's more to do here, e.g. copying from `profiles` without
      going via Python.)
      
      Small tidy-ups while I'm here:
      
      * Remove duplicated code from test_initial. This was meant to be pulled into `purge_and_rebuild_user_dir`.
      * Move `is_public` before updating sharing tables. No functional change; it's still before the first read of `is_public`.
      * Don't bother creating a set from dict keys. Slightly nicer and makes the code simpler.
      
      Co-authored-by: default avatarRichard van der Hoff <1389908+richvdh@users.noreply.github.com>
      Unverified
      4f00432c
  12. Oct 04, 2021
    • David Robertson's avatar
      Consistently exclude from user_directory (#10960) · f7b034a2
      David Robertson authored
      * Introduce `should_include_local_users_in_dir`
      
      We exclude three kinds of local users from the user_directory tables. At
      present we don't consistently exclude all three in the same places. This
      commit introduces a new function to gather those exclusion conditions
      together. Because we have to handle local and remote users in different
      ways, I've made that function only consider the case of remote users.
      It's the caller's responsibility to make the local versus remote
      distinction clear and correct.
      
      A test fixup is required. The test now hits a path which makes db
      queries against the users table. The expected rows were missing, because
      we were using a dummy user that hadn't actually been registered.
      
      We also add new test cases to covert the exclusion logic.
      
      ----
      
      By my reading this makes these changes:
      
      * When an app service user registers or changes their profile, they will
        _not_ be added to the user directory. (Previously only support and
        deactivated users were excluded). This is consistent with the logic that
        rebuilds the user directory. See also [the discussion
        here](https://github.com/matrix-org/synapse/pull/10914#discussion_r716859548
      
      ).
      * When rebuilding the directory, exclude support and disabled users from
        room sharing tables. Previously only appservice users were excluded.
      * Exclude all three categories of local users when rebuilding the
        directory. Previously `_populate_user_directory_process_users` didn't do
        any exclusion.
      
      Co-authored-by: default avatarRichard van der Hoff <1389908+richvdh@users.noreply.github.com>
      Unverified
      f7b034a2
  13. Sep 30, 2021
  14. Apr 14, 2021
  15. Apr 06, 2021
  16. Dec 17, 2020
  17. Aug 27, 2020
  18. Aug 07, 2020
  19. Dec 06, 2019
  20. Oct 21, 2019
  21. May 10, 2019
  22. Mar 18, 2019
  23. Mar 12, 2019
  24. Mar 07, 2019
  25. Sep 03, 2018
  26. Aug 13, 2018
  27. Aug 10, 2018
  28. Jul 09, 2018
  29. Mar 28, 2018
  30. Jan 27, 2018
Loading