- Jul 21, 2022
-
-
Patrick Cloke authored
After this change `synapse.logging` is fully typed.
-
Nick Mills-Barrett authored
This comes from two identical definitions in each of the base stores, and means the base slaved store is now empty and can be removed.
-
David Robertson authored
-
David Teller authored
Resolves #13330. Missed in #13125. Signed-off-by:
David Teller <davidt@element.io>
-
- Jul 20, 2022
-
-
Eric Eastwood authored
Update `get_pdu` to return the untouched, pristine `EventBase` as it was originally seen over federation (no metadata added). Previously, we returned the same `event` reference that we stored in the cache which downstream code modified in place and added metadata like setting it as an `outlier` and essentially poisoned our cache. Now we always return a copy of the `event` so the original can stay pristine in our cache and re-used for the next cache call. Split out from https://github.com/matrix-org/synapse/pull/13205 As discussed at: - https://github.com/matrix-org/synapse/pull/13205#discussion_r918365746 - https://github.com/matrix-org/synapse/pull/13205#discussion_r918366125 Related to https://github.com/matrix-org/synapse/issues/12584. This PR doesn't fix that issue because it hits [`get_event` which exists from the local database before it tries to `get_pdu`](https://github.com/matrix-org/synapse/blob/7864f33e286dec22368dc0b11c06eebb1462a51e/synapse/federation/federation_client.py#L581-L594).
-
Shay authored
-
Erik Johnston authored
-
Erik Johnston authored
This can cause a lot of extra load on servers with lots of appservice users. Introduced in #13078
-
- Jul 19, 2022
-
-
Sean Quah authored
-
Patrick Cloke authored
Functions that are decorated with `trace` are now properly typed and the type hints for them are fixed.
-
Brendan Abolivier authored
-
Erik Johnston authored
-
Patrick Cloke authored
-
Brendan Abolivier authored
-
Andrew Morgan authored
-
villepeh authored
Add another bash script to the contrib directory. It creates multiple stream writers and also prints out the example configuration for homeserver.yaml. Signed-off-by: Ville Petteri Huh.
-
Jörg Behrmann authored
Signed-off-by:
Jörg Behrmann <behrmann@physik.fu-berlin.de>
-
David Robertson authored
-
Nick Mills-Barrett authored
Fix race conditions in the async cache invalidation logic, by separating the async & local invalidation calls and ensuring any async call i executed first. Signed off by Nick @ Beeper (@Fizzadar).
-
- Jul 18, 2022
-
-
Shay authored
-
Shay authored
-
Sean Quah authored
Signed-off-by:
Sean Quah <seanq@matrix.org>
-
Brendan Abolivier authored
Co-authored-by:
David Robertson <davidr@element.io>
-
Andrew Morgan authored
-
Erik Johnston authored
This reverts commit 5d4028f2.
-
Erik Johnston authored
-
Nick Mills-Barrett authored
To close: #10294. Signed off by Nick @ Beeper.
-
Andrew Morgan authored
-
Erik Johnston authored
-
- Jul 17, 2022
-
-
Dirk Klimpel authored
-
Nick Mills-Barrett authored
More prep work for asyncronous caching, also makes all process_replication_rows methods consistent (presence handler already is so). Signed off by Nick @ Beeper (@Fizzadar)
-
- Jul 15, 2022
-
-
Dirk Klimpel authored
-
Eric Eastwood authored
Fix https://github.com/matrix-org/synapse/issues/13016 ## New error code and status ### Before Previously, we returned a `404` for `/thumbnail` which isn't even in the spec. ```json { "errcode": "M_NOT_FOUND", "error": "Not found [b'hs1', b'tefQeZhmVxoiBfuFQUKRzJxc']" } ``` ### After What does the spec say? > 400: The request does not make sense to the server, or the server cannot thumbnail the content. For example, the client requested non-integer dimensions or asked for negatively-sized images. > > *-- https://spec.matrix.org/v1.1/client-server-api/#get_matrixmediav3thumbnailservernamemediaid* Now with this PR, we respond with a `400` when we don't have thumbnails to serve and we explain why we might not have any thumbnails. ```json { "errcode": "M_UNKNOWN", "error": "Cannot find any thumbnails for the requested media ([b'example.com', b'12345']). This might mean the media is not a supported_media_format=(image/jpeg, image/jpg, image/webp, image/gif, image/png) or that thumbnailing failed for some other reason. (Dynamic thumbnails are disabled on this server.)", } ``` > Cannot find any thumbnails for the requested media ([b'example.com', b'12345']). This might mean the media is not a supported_media_format=(image/jpeg, image/jpg, image/webp, image/gif, image/png) or that thumbnailing failed for some other reason. (Dynamic thumbnails are disabled on this server.) --- We still respond with a 404 in many other places. But we can iterate on those later and maybe keep some in some specific places after spec updates/clarification: https://github.com/matrix-org/matrix-spec/issues/1122 We can also iterate on the bugs where Synapse doesn't thumbnail when it should in other issues/PRs.
-
David Robertson authored
-
Erik Johnston authored
-
Patrick Cloke authored
Instead of manually inserting fake data. This fixes some issues with having to manually calculate stream orderings and other oddities.
-
David Robertson authored
Co-authored-by:
Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
-
Sean Quah authored
`frozendict` 2.3.2 includes a fix for a memory leak in `frozendict.__hash__`. This likely has no impact outside of the deprecated `/initialSync` endpoint, which uses `StreamToken`s, containing `RoomStreamToken`s, containing `frozendict`s, as cache keys. Signed-off-by:
Sean Quah <seanq@matrix.org>
-