- Oct 03, 2022
-
-
Erik Johnston authored
Introduced in #13719
-
David Robertson authored
* Try again to automate dependabot changelogs * Changelog
-
lukasdenk authored
MSC3316 declares that both /rooms/{roomId}/send and /rooms/{roomId}/state should accept a ts parameter for appservices. This change expands support to /state and adds tests.
-
David Robertson authored
-
dependabot[bot] authored
* Bump actions/checkout from 2 to 3 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/v2...v3 ) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by:
dependabot[bot] <support@github.com> * Changelog Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by:
David Robertson <davidr@element.io>
-
Erik Johnston authored
-
Sean Quah authored
Instead of running a single large query, run a single query for user-only lookups and additional queries for batches of user device lookups. Resolves #13580. Signed-off-by:
Sean Quah <seanq@matrix.org>
-
David Robertson authored
* Change dependabot CL suffix * Changelog
-
David Robertson authored
-
Erik Johnston authored
Fixes #13990
-
Eric Eastwood authored
* Maybe not catch all errors to avoid things in the nature-of CancelledError See https://github.com/matrix-org/synapse/pull/13815#discussion_r983384698 * Remove general exception tracking * Add changelog
-
- Oct 01, 2022
-
-
Eric Eastwood authored
Spawning from looking into `get_users_in_room` while investigating https://github.com/matrix-org/synapse/issues/13942#issuecomment-1262787050. See https://github.com/matrix-org/synapse/pull/13575#discussion_r953023755 for the original exploration around finding `get_users_in_room` mis-uses. Related to the following PRs where we also cleaned up some `get_users_in_room` mis-uses: - https://github.com/matrix-org/synapse/pull/13605 - https://github.com/matrix-org/synapse/pull/13608 - https://github.com/matrix-org/synapse/pull/13606 - https://github.com/matrix-org/synapse/pull/13958
-
- Sep 30, 2022
-
-
Eric Eastwood authored
Spawned while working on [`get_users_in_room` mis-uses](https://github.com/matrix-org/synapse/pull/13958#discussion_r984074897) and thinking we could use `get_local_users_in_room` here but we can't. From first glance, it seemed like this was only using local users from all of the `is_mine_id(user_id)` checks but I see that it does actually use remote users. Just making things a little more clear here what it does and mentions remote users so maybe that will be more obvious in the future.
-
Erik Johnston authored
-
David Robertson authored
Co-authored-by:
Patrick Cloke <clokep@users.noreply.github.com>
-
David Robertson authored
This reverts commit 6d543d6d.
-
David Robertson authored
* Update mypy and mypy-zope * Unignore assigning to LogRecord attributes Presumably https://github.com/python/typeshed/pull/8064 makes this ok Cherry-picked from #13521 * Remove unused ignores due to mypy ParamSpec fixes https://github.com/python/mypy/pull/12668 Cherry-picked from #13521 * Remove additional unused ignores * Fix new mypy complaints related to `assertGreater` Presumably due to https://github.com/python/typeshed/pull/8077 * Changelog * Reword changelog Co-authored-by:
Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by:
Patrick Cloke <clokep@users.noreply.github.com>
-
Erik Johnston authored
We move the expensive check of visibility to after calculating push actions, avoiding the expensive check for users who won't get pushed anyway. I think this should have a big impact on rooms with large numbers of local users that have pushed disabled.
-
David Robertson authored
Co-authored-by:
Patrick Cloke <clokep@users.noreply.github.com>
-
Dirk Klimpel authored
Signed-off-by:
Dirk Klimpel <dirk@klimpel.org>
-
Erik Johnston authored
Fixes #13942. Introduced in #13575. Basically, let's only get the ordered set of hosts out of the DB if we need an ordered set of hosts. Since we split the function up the caching won't be as good, but I think it will still be fine as e.g. multiple backfill requests for the same room will hit the cache.
-
David Robertson authored
* Reproduce bug * Compute `least_function` first * Substitute `least_function` with an f-string * Bugfix: avoid overflow Co-authored-by:
Eric Eastwood <erice@element.io>
-
Brendan Abolivier authored
-
- Sep 29, 2022
-
-
David Robertson authored
-
David Robertson authored
-
Erik Johnston authored
-
Nick Mills-Barrett authored
-
Brendan Abolivier authored
Allow admins to require a manual approval process before new accounts can be used (using MSC3866) (#13556)
-
Patrick Cloke authored
-
Hugh Nimmo-Smith authored
-
Patrick Cloke authored
By renaming it and updating the docstring. Additionally, refactors a method which is used only by tests.
-
Nicolas Werner authored
-
reivilibre authored
Co-authored-by:
Eric Eastwood <erice@element.io>
-
- Sep 28, 2022
-
-
Erik Johnston authored
-
Eric Eastwood authored
There is no need to grab thousands of backfill points when we only need 5 to make the `/backfill` request with. We need to grab a few extra in case the first few aren't visible in the history. Previously, we grabbed thousands of backfill points from the database, then sorted and filtered them in the app. Fetching the 4.6k backfill points for `#matrix:matrix.org` from the database takes ~50ms - ~570ms so it's not like this saves a lot of time
. But it might save us more time now that `get_backfill_points_in_room`/`get_insertion_event_backward_extremities_in_room` are more complicated after https://github.com/matrix-org/synapse/pull/13635 This PR moves the filtering and limiting to the SQL query so we just have less data to work with in the first place. Part of https://github.com/matrix-org/synapse/issues/13356 -
Patrick Cloke authored
-
Patrick Cloke authored
This reverts commit 7766bd5b (#13933). The unused column is actually used, but much further down in the function.
-
Patrick Cloke authored
-
Andrew Morgan authored
-