Skip to content
Snippets Groups Projects
  1. Feb 11, 2022
  2. Feb 10, 2022
  3. Feb 09, 2022
  4. Feb 08, 2022
  5. Feb 07, 2022
  6. Feb 04, 2022
  7. Feb 03, 2022
  8. Feb 02, 2022
    • Richard van der Hoff's avatar
      Fixes for opentracing scopes (#11869) · 31b554c2
      Richard van der Hoff authored
      `start_active_span` was inconsistent as to whether it would activate the span
      immediately, or wait for `scope.__enter__` to happen (it depended on whether
      the current logcontext already had an associated scope). The inconsistency was
      rather confusing if you were hoping to set up a couple of separate spans before
      activating either.
      
      Looking at the other implementations of opentracing `ScopeManager`s, the
      intention is that it *should* be activated immediately, as the name
      implies. Indeed, the idea is that you don't have to use the scope as a
      contextmanager at all - you can just call `.close` on the result. Hence, our
      cleanup has to happen in `.close` rather than `.__exit__`.
      
      So, the main change here is to ensure that `start_active_span` does activate
      the span, and that `scope.close()` does close the scope.
      
      We also add some tests, which requires a `tracer` param so that we don't have
      to rely on the global variable in unit tests.
      Unverified
      31b554c2
    • Patrick Cloke's avatar
      Invalidate the get_users_in_room{_with_profile} caches only when necessary. (#11878) · a8da0469
      Patrick Cloke authored
      The get_users_in_room and get_users_in_room_with_profiles
      are now only invalidated when the  membership of a room changes,
      instead of during any state change in the room.
      Unverified
      a8da0469
Loading