Skip to content
Snippets Groups Projects
Select Git revision
  • main default protected
  • renovate/nixos-nix-2.x
  • renovate/axum-monorepo
  • morguldir/rocky
  • github/fork/JadedBlueEyes/images
  • github/fork/JadedBlueEyes/federation-allow-list
  • renovate/itertools-0.x
  • renovate/sentry-rust-monorepo
  • renovate/lock-file-maintenance
  • renovate/axum-client-ip-0.x
  • renovate/tokio-tracing-monorepo
  • renovate/opentelemetry-rust-monorepo
  • renovate/hyper-util-0.x
  • renovate/nix-community-cache-nix-action-5.x
  • morguldir/snake-sync
  • strawberry/maybe-knocking
  • strawberry/pr-660-presence-fix
  • github/fork/JadedBlueEyes/dockerhub-description
  • strawberry/morgs-snake-sync-jason-main
  • github/fork/bumpsoo/main
  • v0.5.0-rc2
  • v0.5.0-rc
  • v0.4.7-rc
  • v0.4.6
  • v0.4.6-rc
  • v0.4.5
  • v0.4.5-rc
  • v0.4.4
  • v0.4.3
  • v0.4.2
  • v0.4.1
  • v0.3.4
  • v0.3.3
  • v0.3.2
  • v0.3.1
  • v0.3.0
36 results
Search by author
  • Any Author
  • 🥺 🥺 june
1 author
  1. Jul 08, 2024
  3. Jul 06, 2024
    • Christoph Dittmann's avatar
      Don't send empty presence EDUs · 2bc53139
      Christoph Dittmann authored 
      I run a homeserver whose logs show a high number of incoming empty
presence EDUs originating from the user agent "Conduwuit/0.4.4". They
arrive at a rate of about 2 queries per second per Conduwuit server.

The empty EDUs all look the same, only with `origin_server_ts`
increasing:

```
{"origin":"example.com","origin_server_ts":1720266475601,"edus":[{"edu_type":"m.presence","content":{"push":[]}}]}
```

These updates are unnecessary because they don't do anything. They
only increase network traffic and CPU usage on both sides.

After this commit, the empty presence updates are no longer inserted
into the outgoing event queue.
      2bc53139
  5. Jul 04, 2024
  7. Jul 03, 2024
  9. Jun 30, 2024
  11. Jun 22, 2024
  13. Jun 09, 2024
  15. Jun 06, 2024
  17. Jun 05, 2024
    • 🥺's avatar
      delete unnecessary `real_users_cache`, fix overwriting push_target iter, add... · c738c119
      🥺 authored 
      delete unnecessary `real_users_cache`, fix overwriting push_target iter, add proper function for getting local active users in room

this `real_users_cache` cache seems weird, and i have no idea what
prompted its creation upstream. perhaps they did this because
sqlite was very slow and their rocksdb setup is very poor, so
a "solution" was to stick member counts in memory.
slow iterators, scanning, etc do not apply to conduwuit where
our rocksdb is extremely tuned, and i seriously doubt something
like this would have any real world net-positive performance impact.

also for some reason, there is suspicious logic where we
overwrite the entire push target collection.

both of these things could be a potential cause for receiving
notifications in rooms we've left.

Signed-off-by: default avatarstrawberry <strawberry@puppygock.gay>
      c738c119
  19. Jun 03, 2024
  21. Jun 02, 2024
  23. May 27, 2024
  25. May 22, 2024
  27. May 03, 2024
  29. Apr 26, 2024
  31. Apr 17, 2024
  33. Apr 15, 2024