Skip to content
Snippets Groups Projects
Commit c738c119 authored by 🥺's avatar 🥺 :transgender_flag:
Browse files

delete unnecessary `real_users_cache`, fix overwriting push_target iter, add...

delete unnecessary `real_users_cache`, fix overwriting push_target iter, add proper function for getting local active users in room

this `real_users_cache` cache seems weird, and i have no idea what
prompted its creation upstream. perhaps they did this because
sqlite was very slow and their rocksdb setup is very poor, so
a "solution" was to stick member counts in memory.
slow iterators, scanning, etc do not apply to conduwuit where
our rocksdb is extremely tuned, and i seriously doubt something
like this would have any real world net-positive performance impact.

also for some reason, there is suspicious logic where we
overwrite the entire push target collection.

both of these things could be a potential cause for receiving
notifications in rooms we've left.

Signed-off-by: default avatarstrawberry <strawberry@puppygock.gay>
parent c1227340
No related branches found
No related tags found
1 merge request!426Delete unnecessary real_users_cache, fix receiving notifs for rooms we've left, fix suspicious push_target logic
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment