Empirically, this helped my server considerably when handling gaps in Matrix HQ. The problem was that we would repeatedly call have_seen_events for the same set of (50K or so) auth_events, each of which would take many minutes to complete, even though it's only an index scan.

Signed-off-by: Brad Murray <brad@beeper.com>

... because tags on spans which aren't being sampled get thrown away.

Split out from https://github.com/matrix-org/synapse/pull/9247

Strings:

 - `parse_string`
 - `parse_string_from_args`
 - `parse_strings_from_args`

For comparison with ints:

 - `parse_integer`
 - `parse_integer_from_args`

Previous discussions:

 - https://github.com/matrix-org/synapse/pull/9247#discussion_r573195687
 - https://github.com/matrix-org/synapse/pull/9247#discussion_r574214156
 - https://github.com/matrix-org/synapse/pull/9247#discussion_r573264791



Signed-off-by: Eric Eastwood <erice@element.io>

Implements MSC2414: https://github.com/matrix-org/matrix-doc/pull/2414


See #8551 

Signed-off-by: Callum Brown <callum@calcuode.com>

Synapse 1.35.0rc2 (2021-05-27)
==============================

Bugfixes
--------

- Fix a bug introduced in v1.35.0rc1 when calling the spaces summary API via a GET request. ([\#10079](https://github.com/matrix-org/synapse/issues/10079))

Fixes #10068

Fixes a bug due to conflicting PRs which were merged. (One added a new caller to
a method, the other added a new parameter to the same method.)

we don't need to reload the tls cert if we don't have any tls listeners.

Follow-up to #9280.

* Make `invalidate` and `invalidate_many` do the same thing

... so that we can do either over the invalidation replication stream, and also
because they always confused me a bit.

* Kill off `invalidate_many`

* changelog

In lieu of just always enabling the unstable spaces endpoint and
unstable room version.

* Fix GitHub Actions lint for newsfragments

Signed-off-by: Dan Callahan <danc@element.io>

* Tweak wording of database recommendation in INSTALL.md

Signed-off-by: Aaron Raimist <aaron@raim.ist>

The `only` field takes a string or list of strings per the Circle docs:
https://circleci.com/docs/2.0/configuration-reference/#branches



Signed-off-by: Dan Callahan <danc@element.io>

Signed-off-by: Dirk Klimpel <dirk@klimpel.org>

* Update CAPTCHA documentation to mention turning off verify origin

Signed-off-by: Aaron Raimist <aaron@raim.ist>

Adds an option to complement.sh to run Synapse in worker
mode (instead of the default monolith mode).

Fixes #9970

Signed-off-by: Sergio Miguéns Iglesias <lonyelon@lony.xyz>

Signed-off-by: Jerin J Titus <72017981+jerinjtitus@users.noreply.github.com>

fixes #9979

`keylen` seems to be a thing that is frequently incorrectly set, and we don't really need it.

The only time it was used was to figure out if we had removed a subtree in `del_multi`, which we can do better by changing `TreeCache.pop` to return a different type (`TreeCacheNode`).

Commits should be independently reviewable.

The previous spaces_enabled flag now defaults to true and
is exposed in the sample config.

It looks like a typo copy/paste from `get_state_for_event` above.

* Fix /upload 500'ing when presented a very large image

Catch DecompressionBombError and re-raise as ThumbnailErrors

* Set PIL's MAX_IMAGE_PIXELS to match homeserver.yaml

to get it to bomb out quicker, to load less into memory
in the case of super large images

* Add changelog entry for 10029

https://github.com/matrix-org/synapse/issues/9962 uncovered that we accidentally removed all but one of the presence updates that we store in the database when persisting multiple updates. This could cause users' presence state to be stale.

The bug was fixed in #10014, and this PR just adds a test that failed on the old code, and was used to initially verify the bug.

The test attempts to insert some presence into the database in a batch using `PresenceStore.update_presence`, and then simply pulls it out again.

Fixes: https://github.com/matrix-org/synapse/issues/9962



This is a fix for above problem.

I fixed it by swaping the order of insertion of new records and deletion of old ones. This ensures that we don't delete fresh database records as we do deletes before inserts.

Signed-off-by: Marek Matys <themarcq@gmail.com>