- Jan 13, 2021
-
-
Richard van der Hoff authored
If a user tries to do UI Auth via SSO, but uses the wrong account on the SSO IdP, try to give them a better error. Previously, the UIA would claim to be successful, but then the operation in question would simply fail with "auth fail". Instead, serve up an error page which explains the failure.
-
Richard van der Hoff authored
* Add complete test for UI-Auth-via-SSO. * review comments
-
Richard van der Hoff authored
Enhancements to OIDC configuration handling
-
Patrick Cloke authored
Removes a bare `except Exception` clause and replaces it with catching a specific exception around the portion that might throw.
-
Richard van der Hoff authored
-
Richard van der Hoff authored
-
Patrick Cloke authored
-
Richard van der Hoff authored
Collect all the config options which related to an OIDC provider into a single object.
-
Patrick Cloke authored
This checks that the domain given to `DomainSpecificString.is_valid` (e.g. `UserID`, `RoomAlias`, etc.) is of a valid form. Previously some validation was done on the localpart (e.g. the sigil), but not the domain portion.
-
Erik Johnston authored
-
Erik Johnston authored
-
Erik Johnston authored
-
Richard van der Hoff authored
Some light refactoring of OidcHandler, in preparation for bigger things: * remove inheritance from deprecated BaseHandler * add an object to hold the things that go into a session cookie * factor out a separate class for manipulating said cookies
-
Erik Johnston authored
-
Erik Johnston authored
-
- Jan 12, 2021
-
-
Dirk Klimpel authored
This only applies if the user's data is to be erased.
-
Dan Callahan authored
Fixes #8782
-
Richard van der Hoff authored
If we have integrations with multiple identity providers, when the user does a UI Auth, we need to redirect them to the right one. There are a few steps to this. First of all we actually need to store the userid of the user we are trying to validate in the UIA session, since the /auth/sso/fallback/web request is unauthenticated. Then, once we get the /auth/sso/fallback/web request, we can fish the user id out of the session, and use it to look up the external id mappings, and hence pick an SSO provider for them.
-
Marcus authored
It is expected that the proxy would be on a private IP address so the configured proxy should be connected to regardless of the IP range blacklist.
-
Patrick Cloke authored
-
Dan Callahan authored
Debian package builds were failing for two reasons: 1. Python versions prior to 3.7 throw exceptions when attempting to print Unicode characters under a "C" locale. (#9076) 2. We depended on `dh-systemd` which no longer exists in Debian Bullseye, but is necessary in Ubuntu Xenial. (#9073) Setting `LANG="C.UTF-8"` in the build environment fixes the first issue. See also: https://bugs.python.org/issue19846 The second issue is a bit trickier. The dh-systemd package was merged into debhelper version 9.20160709 and a transitional package left in its wake. The transitional dh-systemd package was removed in Debian Bullseye. However, Ubuntu Xenial ships an older debhelper, and still needs dh-systemd. Thus, builds were failing on Bullseye since we depended on a package which had ceased existing, but we couldn't remove it from the debian/control file and our build scripts because we still needed it for Ubuntu Xenial. We can fix the debian/control issue by listing dh-systemd as an alternative to the newer versions of debhelper. Since dh-systemd declares that it depends on debhelper, Ubuntu Xenial will select its older dh-systemd which will in turn pull in its older debhelper, resulting in no change from the status quo. All other supported releases will satisfy the debhelper dependency constraint and skip the dh-systemd alternative. Build scripts were fixed by unconditionally attempting to install dh-systemd on all releases and suppressing failures. Once we drop support for Ubuntu Xenial, we can revert most of this commit and rely on the version constraint on debhelper in debian/control. Fixes #9076 Fixes #9073 Signed-off-by:
Dan Callahan <danc@element.io>
-
Richard van der Hoff authored
Homeserver.get_ip_from_request() used to be a bit more complicated, but now it is totally redundant. Let's get rid of it.
-
Richard van der Hoff authored
SynapseRequest is in danger of becoming a bit of a dumping-ground for "useful stuff relating to Requests", which isn't really its intention (its purpose is to override render, finished and connectionLost to set up the LoggingContext and write the right entries to the request log). Putting utility functions inside SynapseRequest means that lots of our code ends up requiring a SynapseRequest when there is nothing synapse-specific about the Request at all, and any old twisted.web.iweb.IRequest will do. This increases code coupling and makes testing more difficult. In short: move get_user_agent out to a utility function.
-
- Jan 11, 2021
-
-
David Teller authored
For remote users, only the rooms which the server knows about are returned. Local users have all of their joined rooms returned.
-
Erik Johnston authored
-
Dirk Klimpel authored
-
Erik Johnston authored
-
Richard van der Hoff authored
Factor out the exception handling in the startup code to a utility function, and fix the some logging and exit code stuff.
-
Erik Johnston authored
These tables are unused, and can be dropped now the schema version has been bumped.
-
Erik Johnston authored
Co-authored-by:
Patrick Cloke <clokep@users.noreply.github.com>
-
0xflotus authored
-
Richard van der Hoff authored
-
Jerin J Titus authored
* Dropped last_used column from access_tokens Signed-off-by:
Jerin J Titus <72017981+jerinjtitus@users.noreply.github.com>
-
- Jan 10, 2021
-
-
Matthew Hodgson authored
-
- Jan 08, 2021
-
-
Christopher Rücker authored
This PR adds the missing user_mapping_provider section in oidc.md Signed-off-by:
Christopher Rücker <chris-ruecker@protonmail.com>
-
Erik Johnston authored
-
Richard van der Hoff authored
Add tests for the IdP picker
-
Richard van der Hoff authored
-
Erik Johnston authored
You can't continue using a transaction once an exception has been raised, so catching and dropping the error here is pointless and just causes more errors.
-