Skip to content
Snippets Groups Projects
  1. Jan 12, 2021
    • Richard van der Hoff's avatar
      Kill off `HomeServer.get_ip_from_request()` (#9080) · 0f8945e1
      Richard van der Hoff authored
      Homeserver.get_ip_from_request() used to be a bit more complicated, but now it is totally redundant. Let's get rid of it.
      0f8945e1
    • Richard van der Hoff's avatar
      Remove SynapseRequest.get_user_agent (#9069) · 2ec8ca5e
      Richard van der Hoff authored
      SynapseRequest is in danger of becoming a bit of a dumping-ground for "useful stuff relating to Requests",
      which isn't really its intention (its purpose is to override render, finished and connectionLost to set up the 
      LoggingContext and write the right entries to the request log).
      
      Putting utility functions inside SynapseRequest means that lots of our code ends up requiring a
      SynapseRequest when there is nothing synapse-specific about the Request at all, and any old
      twisted.web.iweb.IRequest will do. This increases code coupling and makes testing more difficult.
      
      In short: move get_user_agent out to a utility function.
      2ec8ca5e
  2. Jan 11, 2021
  3. Jan 10, 2021
  4. Jan 08, 2021
  5. Jan 07, 2021
  6. Jan 06, 2021
Loading