Skip to content
Snippets Groups Projects
Unverified Commit a3ad0452 authored by Erik Johnston's avatar Erik Johnston Committed by GitHub
Browse files

Fix TypeError in synapse.notifier (#7880)

Fixes #7774
parent 852930ad
No related branches found
No related tags found
No related merge requests found
Fix "TypeError in `synapse.notifier`" exceptions.
...@@ -421,6 +421,10 @@ class DeviceHandler(DeviceWorkerHandler): ...@@ -421,6 +421,10 @@ class DeviceHandler(DeviceWorkerHandler):
"""Notify that a user's device(s) has changed. Pokes the notifier, and """Notify that a user's device(s) has changed. Pokes the notifier, and
remote servers if the user is local. remote servers if the user is local.
""" """
if not device_ids:
# No changes to notify about, so this is a no-op.
return
users_who_share_room = await self.store.get_users_who_share_room_with_user( users_who_share_room = await self.store.get_users_who_share_room_with_user(
user_id user_id
) )
...@@ -436,6 +440,10 @@ class DeviceHandler(DeviceWorkerHandler): ...@@ -436,6 +440,10 @@ class DeviceHandler(DeviceWorkerHandler):
user_id, device_ids, list(hosts) user_id, device_ids, list(hosts)
) )
if not position:
# This should only happen if there are no updates, so we bail.
return
for device_id in device_ids: for device_id in device_ids:
logger.debug( logger.debug(
"Notifying about update %r/%r, ID: %r", user_id, device_id, position "Notifying about update %r/%r, ID: %r", user_id, device_id, position
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment