Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
synapse
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Terraform modules
Monitor
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Timo Ley
synapse
Commits
a3ad0452
Unverified
Commit
a3ad0452
authored
4 years ago
by
Erik Johnston
Committed by
GitHub
4 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Fix TypeError in synapse.notifier (#7880)
Fixes #7774
parent
852930ad
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
changelog.d/7880.bugfix
+1
-0
1 addition, 0 deletions
changelog.d/7880.bugfix
synapse/handlers/device.py
+8
-0
8 additions, 0 deletions
synapse/handlers/device.py
with
9 additions
and
0 deletions
changelog.d/7880.bugfix
0 → 100644
+
1
−
0
View file @
a3ad0452
Fix "TypeError in `synapse.notifier`" exceptions.
This diff is collapsed.
Click to expand it.
synapse/handlers/device.py
+
8
−
0
View file @
a3ad0452
...
...
@@ -421,6 +421,10 @@ class DeviceHandler(DeviceWorkerHandler):
"""
Notify that a user
'
s device(s) has changed. Pokes the notifier, and
remote servers if the user is local.
"""
if
not
device_ids
:
# No changes to notify about, so this is a no-op.
return
users_who_share_room
=
await
self
.
store
.
get_users_who_share_room_with_user
(
user_id
)
...
...
@@ -436,6 +440,10 @@ class DeviceHandler(DeviceWorkerHandler):
user_id
,
device_ids
,
list
(
hosts
)
)
if
not
position
:
# This should only happen if there are no updates, so we bail.
return
for
device_id
in
device_ids
:
logger
.
debug
(
"
Notifying about update %r/%r, ID: %r
"
,
user_id
,
device_id
,
position
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment