Signed-off-by: Jason Volk <jason@zemos.net>

see:
- https://github.com/girlbossceo/ruwuma/commit/e9302a955614429ca969eb4c7f561fc87a4f6f15
- https://github.com/element-hq/element-android/issues/8043
- https://github.com/element-hq/element-ios/issues/7405



Signed-off-by: strawberry <strawberry@puppygock.gay>

Jason Volk authored 9 months ago and 🥺 committed 9 months ago

Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: strawberry <strawberry@puppygock.gay>

abstract+add more "users in room" accessors, check membership state on `active_local_joined_users_in_room`

`roomuserid_joined` cf seems unreliable, so in the mean time we need to check
membership state (or maybe this is a more reliable check anyways)

Signed-off-by: strawberry <strawberry@puppygock.gay>

delete unnecessary `real_users_cache`, fix overwriting push_target iter, add proper function for getting local active users in room

this `real_users_cache` cache seems weird, and i have no idea what
prompted its creation upstream. perhaps they did this because
sqlite was very slow and their rocksdb setup is very poor, so
a "solution" was to stick member counts in memory.
slow iterators, scanning, etc do not apply to conduwuit where
our rocksdb is extremely tuned, and i seriously doubt something
like this would have any real world net-positive performance impact.

also for some reason, there is suspicious logic where we
overwrite the entire push target collection.

both of these things could be a potential cause for receiving
notifications in rooms we've left.

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

`swap_remove` is faster if we don't care about the order (O(1))

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

only return `inline` if the detected content-type is an allowed
inline content-type as defined by MSC2702

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

so in theory: guest users, peaking over federation,
and world readable rooms should be allowed to send
read receipts even if they're not joined.

relaxing this check to only allow the read receipt if
the server has at least 1 member in the room makes
some of this still work

Signed-off-by: strawberry <strawberry@puppygock.gay>

i need to either fix static linking, or just make it
dynamic always (but then kinda useless idk)

https://gitlab.com/conduwuit/conduwuit/-/jobs/6953419673#L3155



Signed-off-by: strawberry <strawberry@puppygock.gay>