CPython 3.7 and below had a bug where dict comprehension values are
evaluated before the keys, which meant the bridge parsed the binary
data in the wrong order.

Fixes #127
Might fix #130

Nicolai Søborg authored 4 years ago and Tulir Asokan committed 4 years ago

If FB is giving you a hard time while trying to authenticate, then you might mistakenly login while already being logged in, so move the `redact` command above  "already logged in" check

Previously it would wait for the message ID to come from the echo, but
the echo isn't reliable, so need to do this instead.

Also added a TODO to store the offline threading IDs in the database to
avoid some of the problems that not receiving the message ID can cause.

Adrian Petrescu authored 4 years ago and Tulir Asokan committed 4 years ago

Now it matches mautrix-whatsapp in warning users that this setting will do nothing without the appropriate, non-default, and non-intuitively-named permission already set in homeserver.yaml.

Improvement idea from #10

Especially useful now that the "cookie method" is no longer possible

Nicolai Søborg authored 4 years ago and Tulir Asokan committed 4 years ago

Currently bad requests to the web endpoint will throw exceptions like (making it difficult to play with):

```
[2021-01-20 18:02:40,637] [ERROR@aiohttp.server] Unhandled exception
Traceback (most recent call last):
  File "/path/matrix/mautrix-facebook/mautrix_facebook/web/public.py", line 92, in check_token
    user_id = request.query["user_id"]
KeyError: 'user_id'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/root/.virtualenvs/bridge-fb/lib/python3.8/site-packages/aiohttp/web_protocol.py", line 422, in _handle_request
    resp = await self._request_handler(request)
  File "/root/.virtualenvs/bridge-fb/lib/python3.8/site-packages/aiohttp/web_app.py", line 499, in _handle
    resp = await handler(request)
  File "/path/matrix/mautrix-facebook/mautrix_facebook/web/public.py", line 105, in status
    user = await self.check_token(request)
  File "/path/matrix/mautrix-facebook/mautrix_facebook/web/public.py", line 94, in check_token
    raise web.HTTPBadRequest(body='{"error": "Missing user_id query param"}',
aiohttp.web_exceptions.HTTPBadRequest: Bad Request

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/path/.virtualenvs/bridge-fb/lib/python3.8/site-packages/aiohttp/web_protocol.py", line 485, in start
    resp, reset = await task
  File "/path/.virtualenvs/bridge-fb/lib/python3.8/site-packages/aiohttp/web_protocol.py", line 427, in _handle_request
    status=exc.status, reason=exc.reason, text=exc.text, headers=exc.headers
  File "/path/.virtualenvs/bridge-fb/lib/python3.8/site-packages/aiohttp/web_response.py", line 650, in text
    return self._body.decode(self.charset or "utf-8")
AttributeError: 'StringPayload' object has no attribute 'decode'
```