- Apr 13, 2023
-
-
Patrick Cloke authored
The registration fallback is broken and unspecced. This removes it since there is no plan to spec it. Note that this does not modify the login fallback code.
-
reivilibre authored
Improve robustness when handling a perspective key response by deduplicating received server keys. (#15423) * Change `store_server_verify_keys` to take a `Mapping[(str, str), FKR]` This is because we already can't handle duplicate keys — leads to cardinality violation * Newsfile Signed-off-by:
Olivier Wilkinson (reivilibre) <oliverw@matrix.org> --------- Signed-off-by:
Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
-
reivilibre authored
* Add missing comma * Newsfile Signed-off-by:
Olivier Wilkinson (reivilibre) <oliverw@matrix.org> --------- Signed-off-by:
Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
-
Patrick Cloke authored
This moves `redacts` from being a top-level property to a `content` property in a new room version. MSC2176 (which was previously implemented) states to not `redact` this property.
-
Dirk Klimpel authored
-
Dirk Klimpel authored
-
- Apr 12, 2023
-
-
Will Hunt authored
* raise a ConfigError on an invalid app_service_config_files * changelog * Move config check to read_config * Add test * Ensure list also contains strings
-
- Apr 10, 2023
-
-
dependabot[bot] authored
-
dependabot[bot] authored
-
dependabot[bot] authored
-
dependabot[bot] authored
-
dependabot[bot] authored
-
David Robertson authored
By inlining the typechecking job from backend-meta. This seems to resolve odd errors (maybe due to caching?) to have been seen on Dependabot PRs.
-
- Apr 06, 2023
-
-
Patrick Cloke authored
-
dependabot[bot] authored
* Bump pyopenssl from 23.1.0 to 23.1.1 Bumps [pyopenssl](https://github.com/pyca/pyopenssl) from 23.1.0 to 23.1.1. - [Release notes](https://github.com/pyca/pyopenssl/releases) - [Changelog](https://github.com/pyca/pyopenssl/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/pyopenssl/compare/23.1.0...23.1.1 ) --- updated-dependencies: - dependency-name: pyopenssl dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by:
dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by:
GitHub Actions <github-actions[bot]@users.noreply.github.com> Co-authored-by:
Mathieu Velten <mathieuv@matrix.org> Co-authored-by:
David Robertson <davidr@element.io>
-
David Robertson authored
* Trust dtolnay/rust-toolchain The author is a big deal in the Rust world and I'm happy to trust them. I'm also bored of the dependabot updates tbh. * Changelog
-
dependabot[bot] authored
* Bump types-psycopg2 from 2.9.21.8 to 2.9.21.9 Bumps [types-psycopg2](https://github.com/python/typeshed) from 2.9.21.8 to 2.9.21.9. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits ) --- updated-dependencies: - dependency-name: types-psycopg2 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by:
dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by:
GitHub Actions <github-actions[bot]@users.noreply.github.com> Co-authored-by:
Mathieu Velten <mathieuv@matrix.org> Co-authored-by:
David Robertson <davidr@element.io>
-
dependabot[bot] authored
* Bump types-netaddr from 0.8.0.6 to 0.8.0.7 Bumps [types-netaddr](https://github.com/python/typeshed) from 0.8.0.6 to 0.8.0.7. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits ) --- updated-dependencies: - dependency-name: types-netaddr dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by:
dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by:
GitHub Actions <github-actions[bot]@users.noreply.github.com> Co-authored-by:
David Robertson <davidr@element.io>
-
dependabot[bot] authored
* Bump types-opentracing from 2.4.10.3 to 2.4.10.4 Bumps [types-opentracing](https://github.com/python/typeshed) from 2.4.10.3 to 2.4.10.4. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits ) --- updated-dependencies: - dependency-name: types-opentracing dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by:
dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by:
GitHub Actions <github-actions[bot]@users.noreply.github.com>
-
dependabot[bot] authored
* Bump dawidd6/action-download-artifact from 2.26.0 to 2.26.1 Bumps [dawidd6/action-download-artifact](https://github.com/dawidd6/action-download-artifact) from 2.26.0 to 2.26.1. - [Release notes](https://github.com/dawidd6/action-download-artifact/releases) - [Commits](https://github.com/dawidd6/action-download-artifact/compare/5e780fc7bbd0cac69fc73271ed86edf5dcb72d67...7132ab516fba5f602fafae6fdd4822afa10db76f ) --- updated-dependencies: - dependency-name: dawidd6/action-download-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by:
dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by:
GitHub Actions <github-actions[bot]@users.noreply.github.com>
-
Erik Johnston authored
-
David Robertson authored
* Use setup-go instead of relying on 1.17 to exist See https://github.com/actions/runner-images/issues/7276 * Changelog
-
- Apr 05, 2023
-
-
Patrick Cloke authored
This will be done in a future room version, for now an unstable room version is added which redacts the origin field.
-
Quentin Gliech authored
Refer to the correct field from the response when updating the background update progress.
-
- Apr 04, 2023
-
-
Shay authored
-
Erik Johnston authored
-
Erik Johnston authored
-
Sean Quah authored
This change fixes a rare bug where initial /syncs would fail with a `KeyError` under the following circumstances: 1. A user fast joins a remote room. 2. The user is kicked from the room before the room's full state has been synced. 3. A second local user fast joins the room. 4. Events are backfilled into the room with a higher topological ordering than the original user's leave. They are assigned a negative stream ordering. It's not clear how backfill happened here, since it is expected to be equivalent to syncing the full state. 5. The second local user leaves the room before the room's full state has been synced. The homeserver does not complete the sync. 6. The original user performs an initial /sync with lazy_load_members enabled. * Because they were kicked from the room, the room is included in the /sync response even though the include_leave option is not specified. * To populate the room's timeline, `_load_filtered_recents` / `get_recent_events_for_room` fetches events with a lower stream ordering than the leave event and picks the ones with the highest topological orderings (which are most recent). This captures the backfilled events after the leave, since they have a negative stream ordering. These events are filtered out of the timeline, since the user was not in the room at the time and cannot view them. The sync code ends up with an empty timeline for the room that notably does not include the user's leave event. This seems buggy, but at least we don't disclose events the user isn't allowed to see. * Normally, `compute_state_delta` would fetch the state at the start and end of the room's timeline to generate the sync response. Since the timeline is empty, it fetches the state at `min(now, last event in the room)`, which corresponds with the second user's leave. The state during the entirety of the second user's membership does not include the membership for the first user because of partial state. This part is also questionable, since we are fetching state from outside the bounds of the user's membership. * `compute_state_delta` then tries and fails to find the user's membership in the auth events of timeline events. Because there is no timeline event whose auth events are expected to contain the user's membership, a `KeyError` is raised. Also contains a drive-by fix for a separate unlikely race condition. Signed-off-by:
Sean Quah <seanq@matrix.org>
-
David Robertson authored
* Note that Synapse 1.74 queued a user dir rebuild * Changelog
-
- Apr 03, 2023
-
-
Sean Quah authored
Signed-off-by:
Sean Quah <seanq@matrix.org>
-
Patrick Cloke authored
This uses the specced /_matrix/app/v1/... paths instead of the "legacy" paths. If the homeserver receives an error it will retry using the legacy path.
-
Jason Little authored
* Add IReactorUNIX to ISynapseReactor type hint. * Create listen_unix(). Two options, 'path' to the file and 'mode' of permissions(not umask, recommend 666 as default as nginx/other reverse proxies write to it and it's setup as user www-data) For the moment, leave the option to always create a PID lockfile turned on by default * Create UnixListenerConfig and wire it up. Rename ListenerConfig to TCPListenerConfig, then Union them together into ListenerConfig. This spidered around a bit, but I think I got it all. Metrics and manhole have been placed behind a conditional in case of accidental putting them onto a unix socket. Use new helpers to get if a listener is configured for TLS, and to help create a site tag for logging. There are 2 TODO things in parse_listener_def() to finish up at a later point. * Refactor SynapseRequest to handle logging correctly when using a unix socket. This prevents an exception when an IP address can not be retrieved for a request. * Make the 'Synapse now listening on Unix socket' log line a little prettier. * No silent failures on generic workers when trying to use a unix socket with metrics or manhole. * Inline variables in app/_base.py * Update docstring for listen_unix() to remove reference to a hardcoded permission of 0o666 and add a few comments saying where the default IS declared. * Disallow both a unix socket and a ip/port combo on the same listener resource * Linting * Changelog * review: simplify how listen_unix returns(and get rid of a type: ignore) * review: fix typo from ConfigError in app/homeserver.py * review: roll conditional for http_options.tag into get_site_tag() helper(and add docstring) * review: enhance the conditionals for checking if a port or path is valid, remove a TODO line * review: Try updating comment in get_client_ip_if_available to clarify what is being retrieved and why * Pretty up how 'Synapse now listening on Unix Socket' looks by decoding the byte string. * review: In parse_listener_def(), raise ConfigError if neither socket_path nor port is declared(and fix a typo)
-
dependabot[bot] authored
* Bump serde_json from 1.0.94 to 1.0.95 Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.94 to 1.0.95. - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](https://github.com/serde-rs/json/compare/v1.0.94...v1.0.95 ) --- updated-dependencies: - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by:
dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by:
GitHub Actions <github-actions[bot]@users.noreply.github.com>
-
dependabot[bot] authored
* Bump serde from 1.0.158 to 1.0.159 Bumps [serde](https://github.com/serde-rs/serde) from 1.0.158 to 1.0.159. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](https://github.com/serde-rs/serde/compare/v1.0.158...v1.0.159 ) --- updated-dependencies: - dependency-name: serde dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by:
dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by:
GitHub Actions <github-actions[bot]@users.noreply.github.com>
-
dependabot[bot] authored
* Bump peaceiris/actions-gh-pages from 3.9.2 to 3.9.3 Bumps [peaceiris/actions-gh-pages](https://github.com/peaceiris/actions-gh-pages) from 3.9.2 to 3.9.3. - [Release notes](https://github.com/peaceiris/actions-gh-pages/releases) - [Changelog](https://github.com/peaceiris/actions-gh-pages/blob/main/CHANGELOG.md) - [Commits](https://github.com/peaceiris/actions-gh-pages/compare/bd8c6b06eba6b3d25d72b7a1767993c0aeee42e7...373f7f263a76c20808c831209c920827a82a2847 ) --- updated-dependencies: - dependency-name: peaceiris/actions-gh-pages dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by:
dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by:
GitHub Actions <github-actions[bot]@users.noreply.github.com>
-
- Mar 31, 2023
-
-
Jason Robinson authored
-
Erik Johnston authored
* Revert "Fix registering a device on an account with lots of devices (#15348)" This reverts commit f0d8f66e. * Revert "Delete stale non-e2e devices for users, take 3 (#15183)" This reverts commit 78cdb72c.
-
Olivier Wilkinson (reivilibre) authored
This reverts commit 2a234b78. See #15359 for context.
-
- Mar 30, 2023
-
-
Patrick Cloke authored
Clean-up from adding the thread_id column, which was initially null but backfilled with values. It is desirable to require it to now be non-null. In addition to altering this column to be non-null, we clean up obsolete background jobs, indexes, and just-in-time updating code.
-