Skip to content
Snippets Groups Projects
  1. Oct 01, 2020
  2. Sep 30, 2020
  3. Sep 29, 2020
  4. Sep 28, 2020
  5. Sep 27, 2020
  6. Sep 25, 2020
  7. Sep 24, 2020
    • Andrew Morgan's avatar
      Merge branch 'master' into develop · c77c4a2f
      Andrew Morgan authored
      c77c4a2f
    • Erik Johnston's avatar
      Fix MultiWriteIdGenerator's handling of restarts. (#8374) · f112cfe5
      Erik Johnston authored
      On startup `MultiWriteIdGenerator` fetches the maximum stream ID for
      each instance from the table and uses that as its initial "current
      position" for each writer. This is problematic as a) it involves either
      a scan of events table or an index (neither of which is ideal), and b)
      if rows are being persisted out of order elsewhere while the process
      restarts then using the maximum stream ID is not correct. This could
      theoretically lead to race conditions where e.g. events that are
      persisted out of order are not sent down sync streams.
      
      We fix this by creating a new table that tracks the current positions of
      each writer to the stream, and update it each time we finish persisting
      a new entry. This is a relatively small overhead when persisting events.
      However for the cache invalidation stream this is a much bigger relative
      overhead, so instead we note that for invalidation we don't actually
      care about reliability over restarts (as there's no caches to
      invalidate) and simply don't bother reading and writing to the new table
      in that particular case.
      Unverified
      f112cfe5
Loading