ObserveableDeferred expects its callbacks to be called without any
logcontexts, whereas it turns out we were calling them with the logcontext of
the request which initiated the persistence loop.

It seems wrong that we are attributing work done in the persistence loop to the
request that happened to initiate it, so let's solve this by dropping the
logcontext for it.

(I'm not sure this actually causes any real problems other than messages in the
debug log, but let's clean it up anyway)

Make Counter render floats

Prometheus handles all metrics as floats, and sometimes we store non-integer
values in them (notably, durations in seconds), so let's render them as floats
too.

(Note that the standard client libraries also treat Counters as floats.)

Reinstate media download on thumbnail request

We need to actually download the remote media when we get a request for a
thumbnail.

When using synctl with workers, don't start the main synapse automatically

Add /room/{id}/event/{id} to synapse

Do bcrypt hashing in a background thread

Fix publicised groups GET API (singular) over federation

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

which was missing its fed client API, since there is no other API
it might as well reuse the bulk one and unwrap it

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Update http request metrics before calling servlet

Make sure that we set the servlet name in the metrics object *before* calling
the servlet, in case the servlet throws an exception.

Remove dead code related to default thumbnails

Turns out that there is a valid usecase for retrieving event by id (notably
having received a push), but event ids should be scoped to room, so /event/{id}
is wrong.

Fix flaky test_rooms UTs

Fix broken config UTs

Make indentation of generated log config consistent

pointless function is pointless

Fix flakiness in the UTs caused by the user_directory being updated in the
background

https://github.com/matrix-org/synapse/pull/2755 broke log-config generation,
which in turn broke the unit tests.

(we had a mix of 2- and 4-space indents)

Fix templating error with unban permission message

Fixes https://github.com/matrix-org/synapse/issues/2759



Signed-off-by: Travis Ralston <travpc@gmail.com>

Remove 'verbosity'/'log_file' from generated cfg

... because these only really exist to confuse people nowadays.

Also bring log config more into line with the generated log config, by making `level_for_storage`
apply to the `synapse.storage.SQL` logger rather than `synapse.storage`.

Better logging when login can't find a 3pid

Check missing fields in event_from_pdu_json

Return a 400 rather than a 500 when somebody messes up their send_join

turns out we have two copies of this, and neither needs to be an instance
method