Skip to content
Snippets Groups Projects
  1. Jan 15, 2021
  2. Jan 14, 2021
  3. Jan 13, 2021
  4. Jan 12, 2021
    • Dirk Klimpel's avatar
      Remove user's avatar URL and displayname when deactivated. (#8932) · 7a2e9b54
      Dirk Klimpel authored
      This only applies if the user's data is to be erased.
      Unverified
      7a2e9b54
    • Dan Callahan's avatar
      Announce Python / PostgreSQL deprecation policies (#9085) · 6d91e6ca
      Dan Callahan authored
      Fixes #8782
      Unverified
      6d91e6ca
    • Richard van der Hoff's avatar
      UI Auth via SSO: redirect the user to an appropriate SSO. (#9081) · 789d9eba
      Richard van der Hoff authored
      If we have integrations with multiple identity providers, when the user does a UI Auth, we need to redirect them to the right one.
      
      There are a few steps to this. First of all we actually need to store the userid of the user we are trying to validate in the UIA session, since the /auth/sso/fallback/web request is unauthenticated.
      
      Then, once we get the /auth/sso/fallback/web request, we can fish the user id out of the session, and use it to look up the external id mappings, and hence pick an SSO provider for them.
      Unverified
      789d9eba
    • Marcus's avatar
      Don't apply the IP range blacklist to proxy connections (#9084) · e385c8b4
      Marcus authored
      It is expected that the proxy would be on a private IP address so the
      configured proxy should be connected to regardless of the IP range
      blacklist.
      Unverified
      e385c8b4
    • Patrick Cloke's avatar
    • Dan Callahan's avatar
      Fix failures in Debian packaging (#9079) · fa6deb29
      Dan Callahan authored
      Debian package builds were failing for two reasons:
      
       1. Python versions prior to 3.7 throw exceptions when attempting to print
          Unicode characters under a "C" locale. (#9076)
      
       2. We depended on `dh-systemd` which no longer exists in Debian Bullseye, but
          is necessary in Ubuntu Xenial. (#9073)
      
      Setting `LANG="C.UTF-8"` in the build environment fixes the first issue.
      See also: https://bugs.python.org/issue19846
      
      
      
      The second issue is a bit trickier. The dh-systemd package was merged into
      debhelper version 9.20160709 and a transitional package left in its wake.
      
      The transitional dh-systemd package was removed in Debian Bullseye.
      
      However, Ubuntu Xenial ships an older debhelper, and still needs dh-systemd.
      
      Thus, builds were failing on Bullseye since we depended on a package which had
      ceased existing, but we couldn't remove it from the debian/control file and our
      build scripts because we still needed it for Ubuntu Xenial.
      
      We can fix the debian/control issue by listing dh-systemd as an alternative to
      the newer versions of debhelper. Since dh-systemd declares that it depends on
      debhelper, Ubuntu Xenial will select its older dh-systemd which will in turn
      pull in its older debhelper, resulting in no change from the status quo. All
      other supported releases will satisfy the debhelper dependency constraint and
      skip the dh-systemd alternative.
      
      Build scripts were fixed by unconditionally attempting to install dh-systemd on
      all releases and suppressing failures.
      
      Once we drop support for Ubuntu Xenial, we can revert most of this commit and
      rely on the version constraint on debhelper in debian/control.
      
      Fixes #9076
      Fixes #9073
      
      Signed-off-by: default avatarDan Callahan <danc@element.io>
      Unverified
      fa6deb29
    • Richard van der Hoff's avatar
      Kill off `HomeServer.get_ip_from_request()` (#9080) · 0f8945e1
      Richard van der Hoff authored
      Homeserver.get_ip_from_request() used to be a bit more complicated, but now it is totally redundant. Let's get rid of it.
      Unverified
      0f8945e1
    • Richard van der Hoff's avatar
      Remove SynapseRequest.get_user_agent (#9069) · 2ec8ca5e
      Richard van der Hoff authored
      SynapseRequest is in danger of becoming a bit of a dumping-ground for "useful stuff relating to Requests",
      which isn't really its intention (its purpose is to override render, finished and connectionLost to set up the 
      LoggingContext and write the right entries to the request log).
      
      Putting utility functions inside SynapseRequest means that lots of our code ends up requiring a
      SynapseRequest when there is nothing synapse-specific about the Request at all, and any old
      twisted.web.iweb.IRequest will do. This increases code coupling and makes testing more difficult.
      
      In short: move get_user_agent out to a utility function.
      Unverified
      2ec8ca5e
  5. Jan 11, 2021
Loading