Skip to content
Snippets Groups Projects
Unverified Commit f4697b5e authored by Richard van der Hoff's avatar Richard van der Hoff Committed by GitHub
Browse files

Fix UnboundLocalError in post_urlencoded_get_json (#4460)

This could cause exceptions if the id server returned 4xx responses.
parent 10b89d5c
No related branches found
No related tags found
No related merge requests found
Fix UnboundLocalError in post_urlencoded_get_json
...@@ -333,9 +333,10 @@ class SimpleHttpClient(object): ...@@ -333,9 +333,10 @@ class SimpleHttpClient(object):
"POST", uri, headers=Headers(actual_headers), data=query_bytes "POST", uri, headers=Headers(actual_headers), data=query_bytes
) )
body = yield make_deferred_yieldable(readBody(response))
if 200 <= response.code < 300: if 200 <= response.code < 300:
body = yield make_deferred_yieldable(treq.json_content(response)) defer.returnValue(json.loads(body))
defer.returnValue(body)
else: else:
raise HttpResponseException(response.code, response.phrase, body) raise HttpResponseException(response.code, response.phrase, body)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment