-
- Downloads
Clean up startup for the pusher (#6558)
* Remove redundant python2 support code `str.decode()` doesn't exist on python3, so presumably this code was doing nothing * Filter out pushers with corrupt data When we get a row with unparsable json, drop the row, rather than returning a row with null `data`, which will then cause an explosion later on. * Improve logging when we can't start a pusher Log the ID to help us understand the problem * Make email pusher setup more robust We know we'll have a `data` member, since that comes from the database. What we *don't* know is if that is a dict, and if that has a `brand` member, and if that member is a string.
Showing
- changelog.d/6558.misc 1 addition, 0 deletionschangelog.d/6558.misc
- synapse/push/pusher.py 7 additions, 5 deletionssynapse/push/pusher.py
- synapse/push/pusherpool.py 6 additions, 4 deletionssynapse/push/pusherpool.py
- synapse/rest/client/v1/pusher.py 16 additions, 17 deletionssynapse/rest/client/v1/pusher.py
- synapse/storage/data_stores/main/pusher.py 8 additions, 17 deletionssynapse/storage/data_stores/main/pusher.py
- tests/push/test_email.py 3 additions, 0 deletionstests/push/test_email.py
- tests/push/test_http.py 4 additions, 0 deletionstests/push/test_http.py
Loading
Please register or sign in to comment