Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
synapse
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Monitor
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Maunium
synapse
Commits
d2fd7f7b
Unverified
Commit
d2fd7f7b
authored
2 years ago
by
Patrick Cloke
Committed by
GitHub
2 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Fix a stale comment in get_room_version_id_txn. (#12969)
parent
9dc3293e
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
changelog.d/12969.misc
+1
-0
1 addition, 0 deletions
changelog.d/12969.misc
synapse/storage/databases/main/state.py
+1
-6
1 addition, 6 deletions
synapse/storage/databases/main/state.py
with
2 additions
and
6 deletions
changelog.d/12969.misc
0 → 100644
+
1
−
0
View file @
d2fd7f7b
Fix an inaccurate comment.
This diff is collapsed.
Click to expand it.
synapse/storage/databases/main/state.py
+
1
−
6
View file @
d2fd7f7b
...
...
@@ -127,13 +127,8 @@ class StateGroupWorkerStore(EventsWorkerStore, SQLBaseStore):
NotFoundError: if the room is unknown
"""
# First we try looking up room version from the database, but for old
# rooms we might not have added the room version to it yet so we fall
# back to previous behaviour and look in current state events.
#
# We really should have an entry in the rooms table for every room we
# care about, but let's be a bit paranoid (at least while the background
# update is happening) to avoid breaking existing rooms.
# care about, but let's be a bit paranoid.
room_version
=
self
.
db_pool
.
simple_select_one_onecol_txn
(
txn
,
table
=
"
rooms
"
,
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment