Skip to content
Snippets Groups Projects
Unverified Commit c3ccad77 authored by Patrick Cloke's avatar Patrick Cloke Committed by GitHub
Browse files

Only do restricted join rules signature checks for room versions 8/9. (#10927)

Otherwise the presence of a (bogus, unused) field could cause
auth checks to fail.
parent a8bbf085
No related branches found
No related tags found
No related merge requests found
Fix a bug introduced in Synapse v1.40.0 where the signature checks for room version 8/9 could be applied to earlier room versions in some situations.
...@@ -113,7 +113,8 @@ def check( ...@@ -113,7 +113,8 @@ def check(
raise AuthError(403, "Event not signed by sending server") raise AuthError(403, "Event not signed by sending server")
is_invite_via_allow_rule = ( is_invite_via_allow_rule = (
event.type == EventTypes.Member room_version_obj.msc3083_join_rules
and event.type == EventTypes.Member
and event.membership == Membership.JOIN and event.membership == Membership.JOIN
and "join_authorised_via_users_server" in event.content and "join_authorised_via_users_server" in event.content
) )
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment