Skip to content
Snippets Groups Projects
Unverified Commit bd9821f7 authored by Richard van der Hoff's avatar Richard van der Hoff Committed by GitHub
Browse files

Better error messages from `get_create_event_for_room` (#11638)

"Unknown room" can mean a multitude of things here. To help with debugging, add
some more words to the exception text.
parent 8422a7f7
No related branches found
No related tags found
No related merge requests found
Improve the error messages from `get_create_event_for_room`.
...@@ -177,11 +177,15 @@ class StateGroupWorkerStore(EventsWorkerStore, SQLBaseStore): ...@@ -177,11 +177,15 @@ class StateGroupWorkerStore(EventsWorkerStore, SQLBaseStore):
NotFoundError if the room is unknown NotFoundError if the room is unknown
""" """
state_ids = await self.get_current_state_ids(room_id) state_ids = await self.get_current_state_ids(room_id)
if not state_ids:
raise NotFoundError(f"Current state for room {room_id} is empty")
create_id = state_ids.get((EventTypes.Create, "")) create_id = state_ids.get((EventTypes.Create, ""))
# If we can't find the create event, assume we've hit a dead end # If we can't find the create event, assume we've hit a dead end
if not create_id: if not create_id:
raise NotFoundError("Unknown room %s" % (room_id,)) raise NotFoundError(f"No create event in current state for room {room_id}")
# Retrieve the room's create event and return # Retrieve the room's create event and return
create_event = await self.get_event(create_id) create_event = await self.get_event(create_id)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment