-
- Downloads
Always use the name as the log ID. (#9829)
As far as I can tell our logging contexts are meant to log the request ID, or sometimes the request ID followed by a suffix (this is generally stored in the name field of LoggingContext). There's also code to log the name@memory location, but I'm not sure this is ever used. This simplifies the code paths to require every logging context to have a name and use that in logging. For sub-contexts (created via nested_logging_contexts, defer_to_threadpool, Measure) we use the current context's str (which becomes their name or the string "sentinel") and then potentially modify that (e.g. add a suffix).
Showing
- changelog.d/9829.bugfix 1 addition, 0 deletionschangelog.d/9829.bugfix
- synapse/logging/context.py 4 additions, 10 deletionssynapse/logging/context.py
- synapse/metrics/background_process_metrics.py 4 additions, 11 deletionssynapse/metrics/background_process_metrics.py
- synapse/replication/tcp/protocol.py 1 addition, 1 deletionsynapse/replication/tcp/protocol.py
- synapse/util/metrics.py 9 additions, 5 deletionssynapse/util/metrics.py
- tests/logging/test_terse_json.py 4 additions, 2 deletionstests/logging/test_terse_json.py
- tests/test_federation.py 1 addition, 1 deletiontests/test_federation.py
- tests/util/caches/test_descriptors.py 2 additions, 4 deletionstests/util/caches/test_descriptors.py
Loading