Skip to content
Snippets Groups Projects
Unverified Commit a00462dd authored by Sean Quah's avatar Sean Quah Committed by GitHub
Browse files

Implement cancellation support/protection for module callbacks (#12568)


There's no guarantee that module callbacks will handle cancellation
appropriately. Protect module callbacks with read semantics from
cancellation and avoid swallowing `CancelledError`s that arise.

Other module callbacks, such as the `on_*` callbacks, are presumed to
live on code paths that involve writes and aren't cancellation-friendly.
These module callbacks have been left alone.

Signed-off-by: default avatarSean Quah <seanq@element.io>
parent 8de0faca
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment