-
- Downloads
Implement cancellation support/protection for module callbacks (#12568)
There's no guarantee that module callbacks will handle cancellation
appropriately. Protect module callbacks with read semantics from
cancellation and avoid swallowing `CancelledError`s that arise.
Other module callbacks, such as the `on_*` callbacks, are presumed to
live on code paths that involve writes and aren't cancellation-friendly.
These module callbacks have been left alone.
Signed-off-by:
Sean Quah <seanq@element.io>
Showing
- changelog.d/12568.misc 1 addition, 0 deletionschangelog.d/12568.misc
- synapse/events/presence_router.py 9 additions, 3 deletionssynapse/events/presence_router.py
- synapse/events/spamcheck.py 25 additions, 11 deletionssynapse/events/spamcheck.py
- synapse/events/third_party_rules.py 30 additions, 6 deletionssynapse/events/third_party_rules.py
- synapse/handlers/account_validity.py 2 additions, 1 deletionsynapse/handlers/account_validity.py
- synapse/handlers/auth.py 19 additions, 6 deletionssynapse/handlers/auth.py
Loading
Please register or sign in to comment