Skip to content
Snippets Groups Projects
Commit 8714ff6d authored by David Baker's avatar David Baker
Browse files

Add a DUMMY stage to captcha-only registration flow

This allows the client to complete the email last which is more
natual for the user. Without this stage, if the client would
complete the recaptcha (and terms, if enabled) stages and then the
registration request would complete because you've now completed a
flow, even if you were intending to complete the flow that's the
same except has email auth at the end.

Adding a dummy auth stage to the recaptcha-only flow means it's
always unambiguous which flow the client was trying to complete.
Longer term we should think about changing the protocol so the
client explicitly says which flow it's trying to complete.

vector-im/riot-web#9586
parent c2bb7476
Branches
Tags
No related merge requests found
...@@ -345,7 +345,7 @@ class RegisterRestServlet(RestServlet): ...@@ -345,7 +345,7 @@ class RegisterRestServlet(RestServlet):
if self.hs.config.enable_registration_captcha: if self.hs.config.enable_registration_captcha:
# only support 3PIDless registration if no 3PIDs are required # only support 3PIDless registration if no 3PIDs are required
if not require_email and not require_msisdn: if not require_email and not require_msisdn:
flows.extend([[LoginType.RECAPTCHA]]) flows.extend([[LoginType.RECAPTCHA, LoginType.DUMMY]])
# only support the email-only flow if we don't require MSISDN 3PIDs # only support the email-only flow if we don't require MSISDN 3PIDs
if not require_msisdn: if not require_msisdn:
flows.extend([[LoginType.EMAIL_IDENTITY, LoginType.RECAPTCHA]]) flows.extend([[LoginType.EMAIL_IDENTITY, LoginType.RECAPTCHA]])
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment