-
- Downloads
Prefer `type(x) is int` to `isinstance(x, int)` (#14945)
* Perfer `type(x) is int` to `isinstance(x, int)` This covered all additional instances I could see where `x` was user-controlled. The remaining cases are ``` $ rg -s 'isinstance.*[^_]int' tests/replication/_base.py 576: if isinstance(obj, int): synapse/util/caches/stream_change_cache.py 136: assert isinstance(stream_pos, int) 214: assert isinstance(stream_pos, int) 246: assert isinstance(stream_pos, int) 267: assert isinstance(stream_pos, int) synapse/replication/tcp/external_cache.py 133: if isinstance(result, int): synapse/metrics/__init__.py 100: if isinstance(calls, (int, float)): synapse/handlers/appservice.py 262: assert isinstance(new_token, int) synapse/config/_util.py 62: if isinstance(p, int): ``` which cover metrics, logic related to `jsonschema`, and replication and data streams. AFAICS these are all internal to Synapse * Changelog
Showing
- changelog.d/14945.misc 1 addition, 0 deletionschangelog.d/14945.misc
- synapse/config/_base.py 50 additions, 22 deletionssynapse/config/_base.py
- synapse/config/cache.py 2 additions, 2 deletionssynapse/config/cache.py
- synapse/config/server.py 1 addition, 1 deletionsynapse/config/server.py
- synapse/events/validator.py 2 additions, 2 deletionssynapse/events/validator.py
- synapse/federation/federation_client.py 1 addition, 1 deletionsynapse/federation/federation_client.py
- synapse/handlers/message.py 1 addition, 1 deletionsynapse/handlers/message.py
- synapse/rest/admin/__init__.py 1 addition, 1 deletionsynapse/rest/admin/__init__.py
- synapse/rest/admin/registration_tokens.py 7 additions, 8 deletionssynapse/rest/admin/registration_tokens.py
- synapse/rest/admin/users.py 3 additions, 3 deletionssynapse/rest/admin/users.py
- synapse/rest/client/report_event.py 1 addition, 1 deletionsynapse/rest/client/report_event.py
- synapse/rest/media/v1/oembed.py 1 addition, 1 deletionsynapse/rest/media/v1/oembed.py
- synapse/rest/media/v1/thumbnailer.py 1 addition, 1 deletionsynapse/rest/media/v1/thumbnailer.py
- synapse/storage/databases/main/events.py 3 additions, 3 deletionssynapse/storage/databases/main/events.py
Loading
Please register or sign in to comment