Skip to content
Snippets Groups Projects
Unverified Commit 6d14fdc2 authored by Sean Quah's avatar Sean Quah Committed by GitHub
Browse files

Make sqlite database migrations transactional again, part two (#14926)


#14910 fixed the regression introduced by #13873 where sqlite database
migrations would no longer run inside a transaction. However, it
committed the transaction before Synapse updated its bookkeeping of
which migrations have been run, which means that migrations may be run
again after they have completed successfully.

Leave the transaction open at the end of `executescript`, to restore the
old, correct behaviour. Also make the PostgreSQL behaviour consistent
with SQLite.

Fixes #14909.

Signed-off-by: default avatarSean Quah <seanq@matrix.org>
parent a134e626
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment