-
- Downloads
Improve `reactor_tick_time` metric (#11724)
The existing implementation of the `python_twisted_reactor_tick_time` metric is pretty useless, because it *only* measures the time taken to execute timed calls and callbacks from threads. That neglects everything that happens off the back of I/O, which is obviously quite a lot for us. To improve this, I've hooked into a different place in the reactor - in particular, where it calls `epoll`. That call is the only place it should wait for something to happen - the rest of the loop *should* be quick. I've also removed `python_twisted_reactor_pending_calls`, because I don't believe anyone ever looks at it, and it's a nuisance to populate.
Showing
- changelog.d/11724.misc 1 addition, 0 deletionschangelog.d/11724.misc
- changelog.d/11724.removal 1 addition, 0 deletionschangelog.d/11724.removal
- contrib/prometheus/consoles/synapse.html 0 additions, 16 deletionscontrib/prometheus/consoles/synapse.html
- synapse/metrics/__init__.py 1 addition, 93 deletionssynapse/metrics/__init__.py
- synapse/metrics/_reactor_metrics.py 83 additions, 0 deletionssynapse/metrics/_reactor_metrics.py
Loading
Please register or sign in to comment