Skip to content
Snippets Groups Projects
Unverified Commit 59a15da4 authored by Erik Johnston's avatar Erik Johnston Committed by GitHub
Browse files

Add caching support to media endpoints (#18235)


We do a few things in this PR to better support caching:

1. Change `Cache-Control` header to allow intermediary proxies to cache
media *only* if they revalidate on every request. This means that the
intermediary cache will still send the request to Synapse but with a
`If-None-Match` header, at which point Synapse can check auth and
respond with a 304 and empty content.
2. Add `ETag` response header to all media responses. We hardcode this
to `1` since all media is immutable (beyond being deleted).
3. Check for `If-None-Match` header (after checking for auth), and if it
matches then respond with a 304 and empty body.

---------

Co-authored-by: default avatarAndrew Morgan <1342360+anoadragon453@users.noreply.github.com>
parent a278c0d8
Branches
Tags
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment