Skip to content
Snippets Groups Projects
Unverified Commit 52bfa2d5 authored by Hillery Shay's avatar Hillery Shay Committed by GitHub
Browse files

Update contributing.md to warn against rebasing an open PR. (#10563)


Signed-off-by: default avatarH.Shay <shaysquared@gmail.com>
parent b5de77cf
No related branches found
No related tags found
No related merge requests found
...@@ -252,6 +252,7 @@ To prepare a Pull Request, please: ...@@ -252,6 +252,7 @@ To prepare a Pull Request, please:
4. on GitHub, [create the Pull Request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request); 4. on GitHub, [create the Pull Request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request);
5. add a [changelog entry](#changelog) and push it to your Pull Request; 5. add a [changelog entry](#changelog) and push it to your Pull Request;
6. for most contributors, that's all - however, if you are a member of the organization `matrix-org`, on GitHub, please request a review from `matrix.org / Synapse Core`. 6. for most contributors, that's all - however, if you are a member of the organization `matrix-org`, on GitHub, please request a review from `matrix.org / Synapse Core`.
7. if you need to update your PR, please avoid rebasing and just add new commits to your branch.
## Changelog ## Changelog
......
Update contributing.md to warn against rebasing an open PR.
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment