Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
synapse
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Monitor
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Maunium
synapse
Commits
250ee2ea
Commit
250ee2ea
authored
10 years ago
by
Erik Johnston
Browse files
Options
Downloads
Patches
Plain Diff
AUth the contents of power level events
parent
95037d8d
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
synapse/api/auth.py
+72
-1
72 additions, 1 deletion
synapse/api/auth.py
with
72 additions
and
1 deletion
synapse/api/auth.py
+
72
−
1
View file @
250ee2ea
...
...
@@ -19,7 +19,7 @@ from twisted.internet import defer
from
synapse.api.constants
import
Membership
,
JoinRules
from
synapse.api.errors
import
AuthError
,
StoreError
,
Codes
from
synapse.api.events.room
import
RoomMemberEvent
from
synapse.api.events.room
import
RoomMemberEvent
,
RoomPowerLevelsEvent
from
synapse.util.logutils
import
log_function
import
logging
...
...
@@ -67,6 +67,9 @@ class Auth(object):
else
:
yield
self
.
_can_send_event
(
event
)
if
event
.
type
==
RoomPowerLevelsEvent
.
TYPE
:
yield
self
.
_check_power_levels
(
event
)
defer
.
returnValue
(
True
)
else
:
raise
AuthError
(
500
,
"
Unknown event: %s
"
%
event
)
...
...
@@ -315,3 +318,71 @@ class Auth(object):
403
,
"
You don
'
t have permission to change that state
"
)
@defer.inlineCallbacks
def
_check_power_levels
(
self
,
event
):
current_state
=
yield
self
.
store
.
get_current_state
(
event
.
room_id
,
event
.
type
,
event
.
state_key
,
)
user_level
=
yield
self
.
store
.
get_power_level
(
event
.
room_id
,
event
.
user_id
,
)
if
user_level
:
user_level
=
int
(
user_level
)
else
:
user_level
=
0
old_list
=
current_state
.
content
# FIXME (erikj)
old_people
=
{
k
:
v
for
k
,
v
in
old_list
.
items
()
if
k
.
startswith
(
"
@
"
)}
new_people
=
{
k
:
v
for
k
,
v
in
event
.
content
if
k
.
startswith
(
"
@
"
)}
removed
=
set
(
old_people
.
keys
())
-
set
(
new_people
.
keys
())
added
=
set
(
old_people
.
keys
())
-
set
(
new_people
.
keys
())
same
=
set
(
old_people
.
keys
())
&
set
(
new_people
.
keys
())
for
r
in
removed
:
if
int
(
old_list
.
content
[
r
])
>
user_level
:
raise
AuthError
(
403
,
"
You don
'
t have permission to change that state
"
)
for
n
in
new_people
:
if
int
(
event
.
content
[
n
])
>
user_level
:
raise
AuthError
(
403
,
"
You don
'
t have permission to change that state
"
)
for
s
in
same
:
if
int
(
event
.
content
[
s
])
!=
int
(
old_list
[
s
]):
if
int
(
old_list
[
s
])
>
user_level
:
raise
AuthError
(
403
,
"
You don
'
t have permission to change that state
"
)
if
"
default
"
in
old_list
:
old_default
=
int
(
old_list
[
"
default
"
])
if
old_default
>
user_level
:
raise
AuthError
(
403
,
"
You don
'
t have permission to change that state
"
)
if
"
default
"
in
event
.
content
:
new_default
=
int
(
event
.
content
[
"
default
"
])
if
new_default
>
user_level
:
raise
AuthError
(
403
,
"
You don
'
t have permission to change that state
"
)
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment