Fail cleanly if listener config lacks a 'port'

... otherwise we would fail with a mysterious KeyError or something later.

changelog.d/4616.misc

+Fail cleanly if listener config lacks a 'port'

synapse/config/server.py

@@ -129,6 +129,11 @@ class ServerConfig(Config):
         self.listeners = config.get("listeners", [])
 
         for listener in self.listeners:
+            if not isinstance(listener.get("port", None), int):
+                raise ConfigError(
+                    "Listener configuration is lacking a valid 'port' option"
+                )
+
             bind_address = listener.pop("bind_address", None)
             bind_addresses = listener.setdefault("bind_addresses", [])