Fix the allowed range of valid ordering characters for spaces. (#10002)

\x7F was meant to be \0x7E (~) this was originally incorrect in MSC1772.

Fix the allowed range of valid ordering characters for spaces. (#10002)
206a7b5f · Patrick Cloke · GitHub · 9752849e · 206a7b5f · 206a7b5f
Unverified Commit 206a7b5f authored 3 years ago by Patrick Cloke Committed by GitHub 3 years ago
--- a/changelog.d/10002.bugfix
+++ b/changelog.d/10002.bugfix
+Fix a validation bug introduced in v1.34.0 in the ordering of spaces in the space summary API.
--- a/synapse/handlers/space_summary.py
+++ b/synapse/handlers/space_summary.py
@@ -471,8 +471,8 @@ def _is_suggested_child_event(edge_event: EventBase) -> bool:
    return False
-# Order may only contain characters in the range of \x20 (space) to \x7F (~).
+# Order may only contain characters in the range of \x20 (space) to \x7E (~) inclusive.
-_INVALID_ORDER_CHARS_RE = re.compile(r"[^\x20-\x7F]")
+_INVALID_ORDER_CHARS_RE = re.compile(r"[^\x20-\x7E]")
 def _child_events_comparison_key(child: EventBase) -> Tuple[bool, Optional[str], str]: