Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
synapse
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Monitor
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Maunium
synapse
Commits
12bbcc25
Unverified
Commit
12bbcc25
authored
5 years ago
by
Brendan Abolivier
Browse files
Options
Downloads
Patches
Plain Diff
Add a comprehensive error when failing to register for an ACME account
parent
5820ed90
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
synapse/handlers/acme.py
+13
-1
13 additions, 1 deletion
synapse/handlers/acme.py
with
13 additions
and
1 deletion
synapse/handlers/acme.py
+
13
−
1
View file @
12bbcc25
...
@@ -22,6 +22,7 @@ from twisted.web import server, static
...
@@ -22,6 +22,7 @@ from twisted.web import server, static
from
twisted.web.resource
import
Resource
from
twisted.web.resource
import
Resource
from
synapse.app
import
check_bind_error
from
synapse.app
import
check_bind_error
from
synapse.config
import
ConfigError
logger
=
logging
.
getLogger
(
__name__
)
logger
=
logging
.
getLogger
(
__name__
)
...
@@ -71,7 +72,18 @@ class AcmeHandler(object):
...
@@ -71,7 +72,18 @@ class AcmeHandler(object):
# want it to control where we save the certificates, we have to reach in
# want it to control where we save the certificates, we have to reach in
# and trigger the registration machinery ourselves.
# and trigger the registration machinery ourselves.
self
.
_issuer
.
_registered
=
False
self
.
_issuer
.
_registered
=
False
yield
self
.
_issuer
.
_ensure_registered
()
try
:
yield
self
.
_issuer
.
_ensure_registered
()
except
Exception
:
raise
ConfigError
(
"
Failed to register with the ACME provider. This is likely
"
"
happening because the install is new, and ACME v1 has
"
"
been deprecated by Let
'
s Encrypt and is disabled for
"
"
installs set up after November 2019. At the moment,
"
"
Synapse doesn
'
t support ACME v2. For more info and
"
"
alternative solution, check out
"
"
https://github.com/matrix-org/synapse/blob/master/docs/
"
"
ACME.md#deprecation-of-acme-v1
"
)
@defer.inlineCallbacks
@defer.inlineCallbacks
def
provision_certificate
(
self
):
def
provision_certificate
(
self
):
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment