Merge pull request #4133 from matrix-org/travis/fix-terms-auth

Fix logic error that prevented guests from seeing the privacy policy

changelog.d/4133.feature

+Add `m.login.terms` to the registration flow when consent tracking is enabled. **This makes the template arguments conditionally optional on a new `public_version` variable - update your privacy templates to support this.**

synapse/rest/consent/consent_resource.py

@@ -141,7 +141,7 @@ class ConsentResource(Resource):
         username = parse_string(request, "u", required=False, default="")
         userhmac = None
         has_consented = False
-        public_version = username != ""
+        public_version = username == ""
         if not public_version:
             userhmac = parse_string(request, "h", required=True, encoding=None)