Skip to content
Snippets Groups Projects
  • Erik Johnston's avatar
    b970cb0e
    Refactor request sending to have better excpetions (#4358) · b970cb0e
    Erik Johnston authored
    * Correctly retry and back off if we get a HTTPerror response
    
    * Refactor request sending to have better excpetions
    
    MatrixFederationHttpClient blindly reraised exceptions to the caller
    without differentiating "expected" failures (e.g. connection timeouts
    etc) versus more severe problems (e.g. programming errors).
    
    This commit adds a RequestSendFailed exception that is raised when
    "expected" failures happen, allowing the TransactionQueue to log them as
    warnings while allowing us to log other exceptions as actual exceptions.
    b970cb0e
    History
    Refactor request sending to have better excpetions (#4358)
    Erik Johnston authored
    * Correctly retry and back off if we get a HTTPerror response
    
    * Refactor request sending to have better excpetions
    
    MatrixFederationHttpClient blindly reraised exceptions to the caller
    without differentiating "expected" failures (e.g. connection timeouts
    etc) versus more severe problems (e.g. programming errors).
    
    This commit adds a RequestSendFailed exception that is raised when
    "expected" failures happen, allowing the TransactionQueue to log them as
    warnings while allowing us to log other exceptions as actual exceptions.