Skip to content
Snippets Groups Projects
  • reivilibre's avatar
    a83a337c
    Filter out rooms from the room directory being served to other homeservers... · a83a337c
    reivilibre authored
    Filter out rooms from the room directory being served to other homeservers when those rooms block that homeserver by their Access Control Lists. (#16759)
    
    The idea here being that the directory server shouldn't advertise rooms
    to a requesting server is the requesting server would not be allowed to
    join or participate in the room.
    
    <!--
    Fixes: # <!-- -->
    <!--
    Supersedes: # <!-- -->
    <!--
    Follows: # <!-- -->
    <!--
    Part of: # <!-- -->
    Base: `develop` <!-- git-stack-base-branch:develop -->
    
    <!--
    This pull request is commit-by-commit review friendly. <!-- -->
    <!--
    This pull request is intended for commit-by-commit review. <!-- -->
    
    Original commit schedule, with full messages:
    
    <ol>
    <li>
    
    Pass `from_federation_origin` down into room list retrieval code 
    
    </li>
    <li>
    
    Don't cache /publicRooms response for inbound federated requests 
    
    </li>
    <li>
    
    fixup! Don't cache /publicRooms response for inbound federated requests 
    
    </li>
    <li>
    
    Cap the number of /publicRooms entries to 100 
    
    </li>
    <li>
    
    Simplify code now that you can't request unlimited rooms 
    
    </li>
    <li>
    
    Filter out rooms from federated requests that don't have the correct ACL
    
    </li>
    <li>
    
    Request a handful more when filtering ACLs so that we can try to avoid
    shortchanging the requester
    
    </li>
    </ol>
    
    ---------
    
    Signed-off-by: default avatarOlivier Wilkinson (reivilibre) <oliverw@matrix.org>
    a83a337c
    History
    Filter out rooms from the room directory being served to other homeservers...
    reivilibre authored
    Filter out rooms from the room directory being served to other homeservers when those rooms block that homeserver by their Access Control Lists. (#16759)
    
    The idea here being that the directory server shouldn't advertise rooms
    to a requesting server is the requesting server would not be allowed to
    join or participate in the room.
    
    <!--
    Fixes: # <!-- -->
    <!--
    Supersedes: # <!-- -->
    <!--
    Follows: # <!-- -->
    <!--
    Part of: # <!-- -->
    Base: `develop` <!-- git-stack-base-branch:develop -->
    
    <!--
    This pull request is commit-by-commit review friendly. <!-- -->
    <!--
    This pull request is intended for commit-by-commit review. <!-- -->
    
    Original commit schedule, with full messages:
    
    <ol>
    <li>
    
    Pass `from_federation_origin` down into room list retrieval code 
    
    </li>
    <li>
    
    Don't cache /publicRooms response for inbound federated requests 
    
    </li>
    <li>
    
    fixup! Don't cache /publicRooms response for inbound federated requests 
    
    </li>
    <li>
    
    Cap the number of /publicRooms entries to 100 
    
    </li>
    <li>
    
    Simplify code now that you can't request unlimited rooms 
    
    </li>
    <li>
    
    Filter out rooms from federated requests that don't have the correct ACL
    
    </li>
    <li>
    
    Request a handful more when filtering ACLs so that we can try to avoid
    shortchanging the requester
    
    </li>
    </ol>
    
    ---------
    
    Signed-off-by: default avatarOlivier Wilkinson (reivilibre) <oliverw@matrix.org>