Skip to content
Snippets Groups Projects
  • Eric Eastwood's avatar
    daf498e0
    Fix 500 error on `/messages` when we accumulate more than 5 backward extremities (#11027) · daf498e0
    Eric Eastwood authored
    Found while working on the Gitter backfill script and noticed
    it only happened after we sent 7 batches, https://gitlab.com/gitterHQ/webapp/-/merge_requests/2229#note_665906390
    
    When there are more than 5 backward extremities for a given depth,
    backfill will throw an error because we sliced the extremity list
    to 5 but then try to iterate over the full list. This causes
    us to look for state that we never fetched and we get a `KeyError`.
    
    Before when calling `/messages` when there are more than 5 backward extremities:
    ```
    Traceback (most recent call last):
      File "/usr/local/lib/python3.8/site-packages/synapse/http/server.py", line 258, in _async_render_wrapper
        callback_return = await self._async_render(request)
      File "/usr/local/lib/python3.8/site-packages/synapse/http/server.py", line 446, in _async_render
        callback_return = await raw_callback_return
      File "/usr/local/lib/python3.8/site-packages/synapse/rest/client/room.py", line 580, in on_GET
        msgs = await self.pagination_handler.get_messages(
      File "/usr/local/lib/python3.8/site-packages/synapse/handlers/pagination.py", line 396, in get_messages
        await self.hs.get_federation_handler().maybe_backfill(
      File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 133, in maybe_backfill
        return await self._maybe_backfill_inner(room_id, current_depth, limit)
      File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 386, in _maybe_backfill_inner
        likely_extremeties_domains = get_domains_from_state(states[e_id])
    KeyError: '$zpFflMEBtZdgcMQWTakaVItTLMjLFdKcRWUPHbbSZJl'
    ```
    Fix 500 error on `/messages` when we accumulate more than 5 backward extremities (#11027)
    Eric Eastwood authored
    Found while working on the Gitter backfill script and noticed
    it only happened after we sent 7 batches, https://gitlab.com/gitterHQ/webapp/-/merge_requests/2229#note_665906390
    
    When there are more than 5 backward extremities for a given depth,
    backfill will throw an error because we sliced the extremity list
    to 5 but then try to iterate over the full list. This causes
    us to look for state that we never fetched and we get a `KeyError`.
    
    Before when calling `/messages` when there are more than 5 backward extremities:
    ```
    Traceback (most recent call last):
      File "/usr/local/lib/python3.8/site-packages/synapse/http/server.py", line 258, in _async_render_wrapper
        callback_return = await self._async_render(request)
      File "/usr/local/lib/python3.8/site-packages/synapse/http/server.py", line 446, in _async_render
        callback_return = await raw_callback_return
      File "/usr/local/lib/python3.8/site-packages/synapse/rest/client/room.py", line 580, in on_GET
        msgs = await self.pagination_handler.get_messages(
      File "/usr/local/lib/python3.8/site-packages/synapse/handlers/pagination.py", line 396, in get_messages
        await self.hs.get_federation_handler().maybe_backfill(
      File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 133, in maybe_backfill
        return await self._maybe_backfill_inner(room_id, current_depth, limit)
      File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 386, in _maybe_backfill_inner
        likely_extremeties_domains = get_domains_from_state(states[e_id])
    KeyError: '$zpFflMEBtZdgcMQWTakaVItTLMjLFdKcRWUPHbbSZJl'
    ```