Skip to content
Snippets Groups Projects
  • Sean Quah's avatar
    6d14fdc2
    Make sqlite database migrations transactional again, part two (#14926) · 6d14fdc2
    Sean Quah authored
    
    #14910 fixed the regression introduced by #13873 where sqlite database
    migrations would no longer run inside a transaction. However, it
    committed the transaction before Synapse updated its bookkeeping of
    which migrations have been run, which means that migrations may be run
    again after they have completed successfully.
    
    Leave the transaction open at the end of `executescript`, to restore the
    old, correct behaviour. Also make the PostgreSQL behaviour consistent
    with SQLite.
    
    Fixes #14909.
    
    Signed-off-by: default avatarSean Quah <seanq@matrix.org>
    Make sqlite database migrations transactional again, part two (#14926)
    Sean Quah authored
    
    #14910 fixed the regression introduced by #13873 where sqlite database
    migrations would no longer run inside a transaction. However, it
    committed the transaction before Synapse updated its bookkeeping of
    which migrations have been run, which means that migrations may be run
    again after they have completed successfully.
    
    Leave the transaction open at the end of `executescript`, to restore the
    old, correct behaviour. Also make the PostgreSQL behaviour consistent
    with SQLite.
    
    Fixes #14909.
    
    Signed-off-by: default avatarSean Quah <seanq@matrix.org>