Skip to content
Snippets Groups Projects
  • David Robertson's avatar
    510d4b06
    Handle malformed values of `notification.room` in power level events (#14942) · 510d4b06
    David Robertson authored
    * Better test for bad values in power levels events
    
    The previous test only checked that Synapse didn't raise an exception,
    but didn't check that we had correctly interpreted the value of the
    dodgy power level.
    
    It also conflated two things: bad room notification levels, and bad user
    levels. There _is_ logic for converting the latter to integers, but we
    should test it separately.
    
    * Check we ignore types that don't convert to int
    
    * Handle `None` values in `notifications.room`
    
    * Changelog
    
    * Also test that bad values are rejected by event auth
    
    * Docstring
    
    * linter scripttttttttt
    Handle malformed values of `notification.room` in power level events (#14942)
    David Robertson authored
    * Better test for bad values in power levels events
    
    The previous test only checked that Synapse didn't raise an exception,
    but didn't check that we had correctly interpreted the value of the
    dodgy power level.
    
    It also conflated two things: bad room notification levels, and bad user
    levels. There _is_ logic for converting the latter to integers, but we
    should test it separately.
    
    * Check we ignore types that don't convert to int
    
    * Handle `None` values in `notifications.room`
    
    * Changelog
    
    * Also test that bad values are rejected by event auth
    
    * Docstring
    
    * linter scripttttttttt