Skip to content
Snippets Groups Projects
  • Andrew Morgan's avatar
    3f4a2a70
    Hotfix: disable autoescape by default when rendering Jinja2 templates (#8394) · 3f4a2a70
    Andrew Morgan authored
    #8037 changed the default `autoescape` option when rendering Jinja2 templates from `False` to `True`. This caused some bugs, noticeably around redirect URLs being escaped in SAML2 auth confirmation templates, causing those URLs to break for users.
    
    This change returns the previous behaviour as it stood. We may want to look at each template individually and see whether autoescaping is a good idea at some point, but for now lets just fix the breakage.
    Hotfix: disable autoescape by default when rendering Jinja2 templates (#8394)
    Andrew Morgan authored
    #8037 changed the default `autoescape` option when rendering Jinja2 templates from `False` to `True`. This caused some bugs, noticeably around redirect URLs being escaped in SAML2 auth confirmation templates, causing those URLs to break for users.
    
    This change returns the previous behaviour as it stood. We may want to look at each template individually and see whether autoescaping is a good idea at some point, but for now lets just fix the breakage.