Skip to content
Snippets Groups Projects
  • Kento Okamoto's avatar
    72935b7c
    Add warnings to ip_range_blacklist usage with proxies (#10129) · 72935b7c
    Kento Okamoto authored
    
    Per issue #9812 using `url_preview_ip_range_blacklist` with a proxy via `HTTPS_PROXY` or `HTTP_PROXY` environment variables has some inconsistent bahavior than mentioned. This PR changes the following:
    
    - Changes the Sample Config file to include a note mentioning that `url_preview_ip_range_blacklist` and `ip_range_blacklist` is ignored when using a proxy
    - Changes some logic in synapse/config/repository.py to send a warning when both `*ip_range_blacklist` configs and a proxy environment variable are set and but no longer throws an error.
    
    Signed-off-by: default avatarKento Okamoto <kentokamoto@protonmail.com>
    Add warnings to ip_range_blacklist usage with proxies (#10129)
    Kento Okamoto authored
    
    Per issue #9812 using `url_preview_ip_range_blacklist` with a proxy via `HTTPS_PROXY` or `HTTP_PROXY` environment variables has some inconsistent bahavior than mentioned. This PR changes the following:
    
    - Changes the Sample Config file to include a note mentioning that `url_preview_ip_range_blacklist` and `ip_range_blacklist` is ignored when using a proxy
    - Changes some logic in synapse/config/repository.py to send a warning when both `*ip_range_blacklist` configs and a proxy environment variable are set and but no longer throws an error.
    
    Signed-off-by: default avatarKento Okamoto <kentokamoto@protonmail.com>