Skip to content
Snippets Groups Projects
  1. May 22, 2020
  2. May 01, 2020
  3. Apr 04, 2020
    • Brendan Abolivier's avatar
      Server notices: Dissociate room creation/lookup from invite (#7199) · d73bf18d
      Brendan Abolivier authored
      Fixes #6815
      
      Before figuring out whether we should alert a user on MAU, we call get_notice_room_for_user to get some info on the existing server notices room for this user. This function, if the room doesn't exist, creates it and invites the user in it. This means that, if we decide later that no server notice is needed, the user gets invited in a room with no message in it. This happens at every restart of the server, since the room ID returned by get_notice_room_for_user is cached.
      
      This PR fixes that by moving the inviting bit to a dedicated function, that's only called when the server actually needs to send a notice to the user. A potential issue with this approach is that the room that's created by get_notice_room_for_user doesn't match how that same function looks for an existing room (i.e. it creates a room that doesn't have an invite or a join for the current user in it, so it could lead to a new room being created each time a user syncs), but I'm not sure this is a problem given it's cached until the server restarts, so that function won't run very often.
      
      It also renames get_notice_room_for_user into get_or_create_notice_room_for_user to make what it does clearer.
      Unverified
      d73bf18d
  4. Mar 24, 2020
  5. Oct 24, 2019
  6. Jul 30, 2019
    • Richard van der Hoff's avatar
      Remove non-functional 'expire_access_token' setting (#5782) · 8c97f641
      Richard van der Hoff authored
      The `expire_access_token` didn't do what it sounded like it should do. What it
      actually did was make Synapse enforce the 'time' caveat on macaroons used as
      access tokens, but since our access token macaroons never contained such a
      caveat, it was always a no-op.
      
      (The code to add 'time' caveats was removed back in v0.18.5, in #1656)
      Unverified
      8c97f641
  7. Jun 20, 2019
  8. May 13, 2019
  9. May 10, 2019
  10. Mar 21, 2019
  11. Mar 19, 2019
  12. Oct 25, 2018
  13. Sep 06, 2018
  14. Aug 24, 2018
  15. Aug 23, 2018
  16. Aug 22, 2018
  17. Aug 17, 2018
  18. Aug 16, 2018
  19. Aug 10, 2018
Loading