- Jul 18, 2022
-
-
Andrew Morgan authored
-
Erik Johnston authored
This reverts commit 5d4028f2.
-
Erik Johnston authored
-
Nick Mills-Barrett authored
To close: #10294. Signed off by Nick @ Beeper.
-
Andrew Morgan authored
-
Erik Johnston authored
-
- Jul 17, 2022
-
-
Dirk Klimpel authored
-
Nick Mills-Barrett authored
More prep work for asyncronous caching, also makes all process_replication_rows methods consistent (presence handler already is so). Signed off by Nick @ Beeper (@Fizzadar)
-
- Jul 15, 2022
-
-
Dirk Klimpel authored
-
Eric Eastwood authored
Fix https://github.com/matrix-org/synapse/issues/13016 ## New error code and status ### Before Previously, we returned a `404` for `/thumbnail` which isn't even in the spec. ```json { "errcode": "M_NOT_FOUND", "error": "Not found [b'hs1', b'tefQeZhmVxoiBfuFQUKRzJxc']" } ``` ### After What does the spec say? > 400: The request does not make sense to the server, or the server cannot thumbnail the content. For example, the client requested non-integer dimensions or asked for negatively-sized images. > > *-- https://spec.matrix.org/v1.1/client-server-api/#get_matrixmediav3thumbnailservernamemediaid* Now with this PR, we respond with a `400` when we don't have thumbnails to serve and we explain why we might not have any thumbnails. ```json { "errcode": "M_UNKNOWN", "error": "Cannot find any thumbnails for the requested media ([b'example.com', b'12345']). This might mean the media is not a supported_media_format=(image/jpeg, image/jpg, image/webp, image/gif, image/png) or that thumbnailing failed for some other reason. (Dynamic thumbnails are disabled on this server.)", } ``` > Cannot find any thumbnails for the requested media ([b'example.com', b'12345']). This might mean the media is not a supported_media_format=(image/jpeg, image/jpg, image/webp, image/gif, image/png) or that thumbnailing failed for some other reason. (Dynamic thumbnails are disabled on this server.) --- We still respond with a 404 in many other places. But we can iterate on those later and maybe keep some in some specific places after spec updates/clarification: https://github.com/matrix-org/matrix-spec/issues/1122 We can also iterate on the bugs where Synapse doesn't thumbnail when it should in other issues/PRs.
-
David Robertson authored
-
Erik Johnston authored
-
Patrick Cloke authored
Instead of manually inserting fake data. This fixes some issues with having to manually calculate stream orderings and other oddities.
-
David Robertson authored
Co-authored-by:
Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
-
Sean Quah authored
`frozendict` 2.3.2 includes a fix for a memory leak in `frozendict.__hash__`. This likely has no impact outside of the deprecated `/initialSync` endpoint, which uses `StreamToken`s, containing `RoomStreamToken`s, containing `frozendict`s, as cache keys. Signed-off-by:
Sean Quah <seanq@matrix.org>
-
Richard van der Hoff authored
These columns were added back in Synapse 1.52, and have been populated for new events since then. It's now (beyond) time to back-populate them for existing events.
-
Erik Johnston authored
There are two fixes here: 1. A long-standing bug where we incorrectly calculated `delta_ids`; and 2. A bug introduced in #13267 where we got current state incorrect.
-
Richard van der Hoff authored
When building the docker images for complement testing, copy a preinstalled complement over from a base image, rather than apt installing it. This avoids network traffic and is much faster.
-
Nick Mills-Barrett authored
Some experimental prep work to enable external event caching based on #9379 & #12955. Doesn't actually move the cache at all, just lays the groundwork for async implemented caches. Signed off by Nick @ Beeper (@Fizzadar)
-
Nick Mills-Barrett authored
* Replace `get_new_events_for_appservice` with `get_all_new_events_stream` The functions were near identical and this brings the AS worker closer to the way federation senders work which can allow for multiple workers to handle AS traffic. * Pull received TS alongside events when processing the stream This avoids an extra query -per event- when both federation sender and appservice pusher process events.
-
- Jul 14, 2022
-
-
Richard van der Hoff authored
There is a corner in `_check_event_auth` (long known as "the weird corner") where, if we get an event with auth_events which don't match those we were expecting, we attempt to resolve the diffence between our state and the remote's with a state resolution. This isn't specced, and there's general agreement we shouldn't be doing it. However, it turns out that the faster-joins code was relying on it, so we need to introduce something similar (but rather simpler) for that.
-
Richard van der Hoff authored
-
Erik Johnston authored
-
- Jul 13, 2022
-
-
David Robertson authored
Co-authored-by:
Patrick Cloke <clokep@users.noreply.github.com>
-
David Robertson authored
-
Jacek Kuśnierz authored
* Drop support for v1 unbind Signed-off-by:
Jacek Kusnierz <jacek.kusnierz@tum.de> * Add changelog Signed-off-by:
Jacek Kusnierz <jacek.kusnierz@tum.de> * Update changelog.d/13240.misc
-
Shay authored
-
jejo86 authored
* Admin API request explanation improved Pointed out, that the Admin API is not accessible by default from any remote computer, but only from the PC `matrix-synapse` is running on. Added a full, working example, making sure to include the cURL flag `-X`, which needs to be prepended to `GET`, `POST`, `PUT` etc. and listing the full query string including protocol, IP address and port. * Admin API request explanation improved * Apply suggestions from code review Update changelog. Reword prose. Co-authored-by:
David Robertson <david.m.robertson1@gmail.com>
-
Nick Mills-Barrett authored
-
Patrick Cloke authored
-
Brad Murray authored
-
Patrick Cloke authored
These tables have been unused since Synapse v1.61.0, although schema version 72 was added in Synapse v1.62.0.
-
Patrick Cloke authored
-
Thomas Weston authored
Co-authored-by:
Thomas Weston <thomas.weston@clearspancloud.com> Co-authored-by:
David Robertson <david.m.robertson1@gmail.com>
-
- Jul 12, 2022
-
-
Patrick Cloke authored
Inline URL preview documentation near the implementation.
-
Richard van der Hoff authored
This is unused since Synapse 1.60.0 (#12679). It's time for it to go.
-
Jacek Kuśnierz authored
Drop support for calling `/_matrix/client/v3/account/3pid/bind` without an `id_access_token` (#13239) Fixes #13201 Signed-off-by:
Jacek Kusnierz <jacek.kusnierz@tum.de>
-
David Robertson authored
-
Richard van der Hoff authored
* Drop support for delegating email validation Delegating email validation to an IS is insecure (since it allows the owner of the IS to do a password reset on your HS), and has long been deprecated. It will now cause a config error at startup. * Update unit test which checks for email verification Give it an `email` config instead of a threepid delegate * Remove unused method `requestEmailToken` * Simplify config handling for email verification Rather than an enum and a boolean, all we need here is a single bool, which says whether we are or are not doing email verification. * update docs * changelog * upgrade.md: fix typo * update version number this will be in 1.64, not 1.63 * update version number this one too
-
Sean Quah authored
The stack is already logged when waiting for an event to be un-partial stated. Log the stack for rooms as well, to aid in debugging.
-