Fixes a merge conflict with debian/changelog

Signed-off-by: Dan Callahan <danc@element.io>

Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>

This avoids filtering against fields which cannot exist on an
event source. E.g. presence updates don't have a room.

Fixes: #9346

Includes both the stable and unstable identifier to store-invite
calls to the identity server. In the future we should remove the
unstable identifier.

The DNS threadpool must be explicitly stopped, otherwise Synapse will
hang indefinitely when asked to shut down.

For some reason the query optimiser decided to seq scan both tables,
rather than index scanning `event_json`.

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

This is to stop large bursts of lookups starving out other users of the
thread pools.

Fixes #11049.

Users admin API can now also modify user
type in addition to allowing it to be
set on user creation.

Signed-off-by: Jason Robinson <jasonr@matrix.org>
Co-authored-by: Brendan Abolivier <babolivier@matrix.org>

Introduced in #10548

See https://github.com/matrix-org/synapse-email-account-validity/runs/3979337154?check_suite_focus=true for an example of a module's CI choking over this issue.

Fixes: #10929 

Signed-off-by: Andrew Ferrazzutti <fair@miscworks.net>

This is the final piece of the jigsaw for #9595. As with other changes before this one (eg #10771), we need to make sure that we auth the auth events in the right order, and actually check that their predecessors haven't been rejected.

To do this I've reused the existing code we use when persisting outliers elsewhere.

I've removed the code for attempting to fetch missing auth_events - the events should have been present in the send_join response, so the likely reason they are missing is that we couldn't verify them, so requesting them again is unlikely to help. Instead, we simply drop any state which relies on those auth events, as we do at a backwards-extremity. See also matrix-org/complement#216 for a test for this.

Signed-off-by: Dan Callahan <danc@element.io>

Use $(...) notation instead of legacy backticked `...`.

https://github.com/koalaman/shellcheck/wiki/SC2006



Signed-off-by: Dan Callahan <danc@element.io>

Consider using { cmd1; cmd2; } >> file instead of individual redirects.

https://github.com/koalaman/shellcheck/wiki/SC2129



Signed-off-by: Dan Callahan <danc@element.io>

Double quote to prevent globbing and word splitting.

https://github.com/koalaman/shellcheck/wiki/SC2086



Signed-off-by: Dan Callahan <danc@element.io>

Use find instead of ls to better handle non-alphanumeric filenames.

https://github.com/koalaman/shellcheck/wiki/SC2012



Signed-off-by: Dan Callahan <danc@element.io>

Expressions don't expand in single quotes, use double quotes for that.

https://github.com/koalaman/shellcheck/wiki/SC2016



This specifically warned about the '$aregis...' part of the sed script.
Which is a relatively obscure use of sed.

Splitting this into two commands makes its intent more obvious and
avoids contravening Shellcheck's lints.

Signed-off-by: Dan Callahan <danc@element.io>

Not following: (error message here)

https://github.com/koalaman/shellcheck/wiki/SC1091



Signed-off-by: Dan Callahan <danc@element.io>

This \o will be a regular 'o' in this context.

https://github.com/koalaman/shellcheck/wiki/SC1001



Signed-off-by: Dan Callahan <danc@element.io>

SC2089: Quotes/backslashes will be treated literally. Use an array.

https://github.com/koalaman/shellcheck/wiki/SC2089

SC2090: Quotes/backslashes in this variable will not be respected.

https://github.com/koalaman/shellcheck/wiki/SC2090



Putting literal JSON in a variable mistakenly triggers these warnings.
Instead of adding ignore directives, this can be avoided by inlining the
JSON data into the curl invocation.

Since the variable is only used in this one location, inlining is fine.

Signed-off-by: Dan Callahan <danc@element.io>

Declare and assign separately to avoid masking return values.

https://github.com/koalaman/shellcheck/wiki/SC2155



Signed-off-by: Dan Callahan <danc@element.io>

Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.

https://github.com/koalaman/shellcheck/wiki/SC2166



Signed-off-by: Dan Callahan <danc@element.io>

var is referenced but not assigned.

https://github.com/koalaman/shellcheck/wiki/SC2154



Signed-off-by: Dan Callahan <danc@element.io>

Use single quotes, otherwise this expands now rather than when signalled.

https://github.com/koalaman/shellcheck/wiki/SC2064



Signed-off-by: Dan Callahan <danc@element.io>